feat: container image digest pinning in actions-lock.json with update/upgrade integration#25619
Draft
feat: container image digest pinning in actions-lock.json with update/upgrade integration#25619
Conversation
- Extend ActionCache with ContainerPins map (stored in actions-lock.json) - Add ContainerPin type with image, digest, and pinned_image fields - Modify collectDockerImages to apply cached digest pins and store images in WorkflowData - Add DockerImages field to WorkflowData for header/manifest tracking - Extend GHAWManifest with containers field (in gh-aw-manifest JSON) - Add Container images used: section to lock file header comments - Create UpdateContainerPins CLI function that resolves digests via Docker - Integrate container pin update into upgrade command (step 3b) - Recompile all lock files with updated manifest and header format Agent-Logs-Url: https://github.com/github/gh-aw/sessions/688c5141-cf5f-4a69-9935-1dad34a50e18 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix container image pull with SHA-256 digest pinning
feat: container image digest pinning in actions-lock.json with upgrade integration
Apr 10, 2026
Collaborator
|
…o manifest, add update command integration - Rename ActionCache JSON key from container_pins to containers - Add GHAWManifestContainer type with image/digest/pinned_image fields - Change GHAWManifest.Containers from []string to []GHAWManifestContainer - Track DockerImagePins []GHAWManifestContainer in WorkflowData for manifest - Add UpdateContainerPins to update command (not just upgrade) - Recompile all lock files Agent-Logs-Url: https://github.com/github/gh-aw/sessions/0d5cf327-a467-40fa-8347-f0e797db7dd4 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Done in 88fe858:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
feat: container image digest pinning in actions-lock.json with upgrade integration
feat: container image digest pinning in actions-lock.json with update/upgrade integration
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All MCP container images (
node:lts-alpine,ghcr.io/github/gh-aw-firewall/*,ghcr.io/github/gh-aw-mcpg,ghcr.io/github/github-mcp-server) were pulled by mutable tag with no SHA-256 pinning —node:lts-alpineis additionally floating across LTS generations. This extends the existing action-pin infrastructure to cover Docker images.Storage —
actions-lock.jsonNew
containerssection alongsideentries, keyed by image tag:{ "entries": { ... }, "containers": { "node:lts-alpine": { "image": "node:lts-alpine", "digest": "sha256:abc123...", "pinned_image": "node:lts-alpine@sha256:abc123..." } } }ActionCachegainsGetContainerPin/SetContainerPin/DeleteContainerPin. Loading a legacy file (nocontainers) is fully backward-compatible.Compilation
collectDockerImagesapplies cached pins, substitutingtag@sha256:…for any image with a stored entry.WorkflowData.DockerImagesaccumulates the resolved (possibly pinned) refs so they can be surfaced in the lock file.WorkflowData.DockerImagePinsaccumulates fullGHAWManifestContainerentries (image, digest, pinned_image) for the manifest.# Container images used:comment section.gh-aw-manifestJSON gains a"containers":[…]field with full structured container info including SHA-256 digest when available:Update/Upgrade integration —
pkg/cli/update_container_pins.goUpdateContainerPins()is called from bothgh aw updateandgh aw upgrade(after action pins, before compile):.lock.ymlfiles fordownload_docker_images.shinvocations to discover in-use image tags.docker buildx imagetools inspect(no pull required); falls back todocker pull+docker inspect.actions-lock.json; next compile embeds the@sha256:…suffix.