Skip to content

fix: sync test assertions with capitalized "GitHub toolsets" message #17935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Feb 23, 2026
+6 −6
Merged

fix: sync test assertions with capitalized "GitHub toolsets" message #17935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe92906
Initial plan
Copilot Feb 23, 2026
b4628b6
fix: update tests to match capitalized "GitHub toolsets" in permissio…
Copilot Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/workflow/permissions_no_github_tool_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ tools:
`,
expectError: false,
expectWarning: true,
warningMessage: "Missing required permissions for github toolsets:",
warningMessage: "Missing required permissions for GitHub toolsets:",
},
{
name: "no permissions, no github tool - no warning",
Expand Down
6 changes: 3 additions & 3 deletions pkg/workflow/permissions_validator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ func TestFormatValidationMessage(t *testing.T) {
},
strict: false,
expectContains: []string{
"Missing required permissions for github toolsets:",
"Missing required permissions for GitHub toolsets:",
"contents: write (required by repos)",
"issues: write (required by issues)",
"Option 1: Add missing permissions to your workflow frontmatter:",
Expand Down Expand Up @@ -351,7 +351,7 @@ func TestValidatePermissions_ComplexScenarios(t *testing.T) {
ReadOnly: false,
},
expectMsg: []string{
"Missing required permissions for github toolsets:",
"Missing required permissions for GitHub toolsets:",
"contents: write",
"issues: write",
"pull-requests: write",
Expand All @@ -365,7 +365,7 @@ func TestValidatePermissions_ComplexScenarios(t *testing.T) {
ReadOnly: false,
},
expectMsg: []string{
"Missing required permissions for github toolsets:",
"Missing required permissions for GitHub toolsets:",
"discussions: write",
},
},
Expand Down
4 changes: 2 additions & 2 deletions pkg/workflow/permissions_warning_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ tools:
strict: false,
expectError: false,
expectWarning: true,
warningMessage: "Missing required permissions for github toolsets:",
warningMessage: "Missing required permissions for GitHub toolsets:",
},
{
name: "missing permissions in strict mode produces error",
Expand Down Expand Up @@ -214,7 +214,7 @@ tools:

// Check that the warning includes both options
expectedPhrases := []string{
"Missing required permissions for github toolsets:",
"Missing required permissions for GitHub toolsets:",
"Option 1: Add missing permissions to your workflow frontmatter:",
"Option 2: Reduce the required toolsets in your workflow:",
"issues",
Expand Down