Skip to content

Remove proxy-cached feature flag #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
+12 −26
Draft

Remove proxy-cached feature flag #1600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1dc5b9
Initial plan
Copilot Jan 16, 2026
a3bd7b8
Remove proxy-cached feature flag
Copilot Jan 16, 2026
6d4cf2a
Remove PROXY_CACHE environment variable
Copilot Jan 16, 2026
bb0ccea
Update __tests__/updater-builder-integration.test.ts
pavera Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions __tests__/proxy-integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ integration('ProxyBuilder', () => {
}
]

const cachedMode = true
const builder = new ProxyBuilder(docker, PROXY_IMAGE_NAME, cachedMode)
const builder = new ProxyBuilder(docker, PROXY_IMAGE_NAME)

beforeAll(async () => {
await ImageService.pull(PROXY_IMAGE_NAME)
Expand Down
12 changes: 6 additions & 6 deletions __tests__/updater-builder-integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ integration('UpdaterBuilder', () => {
})

it('createUpdaterContainer returns a container only connected to the internal network', async () => {
const cachedMode = true
const proxy = await new ProxyBuilder(
docker,
PROXY_IMAGE_NAME,
cachedMode
).run(1, dependabotApiUrl, jobToken, credentials)
const proxy = await new ProxyBuilder(docker, PROXY_IMAGE_NAME).run(
1,
jobToken,
dependabotApiUrl,
credentials
)
await proxy.container.start()
const input = {job: details}
const params = new JobParameters(
Expand Down
8 changes: 2 additions & 6 deletions dist/main/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/main/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 1 addition & 3 deletions src/proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@ export type Proxy = {
export class ProxyBuilder {
constructor(
private readonly docker: Docker,
private readonly proxyImage: string,
private readonly cachedMode: boolean
private readonly proxyImage: string
) {}

async run(
Expand Down Expand Up @@ -233,7 +232,6 @@ export class ProxyBuilder {
`no_proxy=${process.env.no_proxy || process.env.NO_PROXY || ''}`,
`JOB_ID=${jobId}`,
`JOB_TOKEN=${jobToken}`,
`PROXY_CACHE=${this.cachedMode ? 'true' : 'false'}`,
`DEPENDABOT_API_URL=${dependabotApiUrl}`,
`ACTIONS_ID_TOKEN_REQUEST_TOKEN=${process.env.ACTIONS_ID_TOKEN_REQUEST_TOKEN || ''}`,
`ACTIONS_ID_TOKEN_REQUEST_URL=${process.env.ACTIONS_ID_TOKEN_REQUEST_URL || ''}`
Expand Down
9 changes: 1 addition & 8 deletions src/updater.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,7 @@ export class Updater {
* Execute an update job and report the result to Dependabot API.
*/
async runUpdater(): Promise<boolean> {
const cachedMode =
this.details.experiments?.hasOwnProperty('proxy-cached') === true

const proxyBuilder = new ProxyBuilder(
this.docker,
this.proxyImage,
cachedMode
)
const proxyBuilder = new ProxyBuilder(this.docker, this.proxyImage)

const proxy = await proxyBuilder.run(
this.apiClient.params.jobId,
Expand Down
Loading