fix(python): add timeout parameter to FleetApi.start()#548
Open
haosenwang1018 wants to merge 1 commit intogithub:mainfrom
Open
fix(python): add timeout parameter to FleetApi.start()#548haosenwang1018 wants to merge 1 commit intogithub:mainfrom
haosenwang1018 wants to merge 1 commit intogithub:mainfrom
Conversation
fleet.start is a long-running blocking RPC that only responds once the fleet completes and the session goes idle. It inherits the default 30s timeout from JsonRpcClient.request(), making it unusable for any non-trivial workload (github#539). Add an explicit timeout parameter (default 600s) and pass it through to the underlying request() call. Fixes github#539
|
It’s a good solution, but there is another problem fleet.start returns started = True after the fleet completes its tasks, not when the fleet is just deployed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FleetApi.start()inherits the default 30s timeout fromJsonRpcClient.request(), butsession.fleet.startis a blocking RPC that only responds once the fleet completes. Any workload taking more than 30s raisesasyncio.TimeoutError(#539).Fix
Add an explicit
timeoutkeyword parameter toFleetApi.start()(default: 600s) and pass it through toself._client.request().Fixes #539