fix: correct 'GithubToken' casing to 'GitHubToken' in .NET and Go by SteveSandersonMS · Pull Request #541 · github/copilot-sdk

SteveSandersonMS · 2026-02-23T12:09:57Z

Rename GithubToken to GitHubToken (capital H) across all .NET and Go type definitions, client code, tests, test scenarios, and READMEs to match the correct 'GitHub' brand casing.

This is a clean recreation of the casing fix from #453 (by @aaronpowell), but:

Excludes unrelated doc formatting changes
Covers all 53 files that reference the field, including test/scenarios/ Go and C# programs that Correct casing of GitHub in types for .NET and Go #453 missed (14 files only)

Not updating Python and TypeScript as they use lowercase-first properties (github_token / githubToken), which are already correct per language convention.

Rename GithubToken to GitHubToken (capital H) across all .NET and Go type definitions, client code, tests, test scenarios, and READMEs to match the correct 'GitHub' brand casing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ibility Adds a deprecated GithubToken property that forwards to GitHubToken, allowing existing consumers to migrate without breaking changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR corrects the public option/property casing from GithubToken to GitHubToken across the Go and .NET SDKs and their related scenario programs/tests/READMEs, aligning with GitHub brand casing.

Changes:

Renames GithubToken → GitHubToken in Go ClientOptions and all usages (client logic, tests, e2e harness).
Renames GithubToken → GitHubToken in .NET CopilotClientOptions and all usages (client logic, tests, e2e harness).
Updates Go/.NET scenario programs and READMEs to use the corrected name.

Reviewed changes

Copilot reviewed 53 out of 53 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/scenarios/transport/stdio/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/transport/stdio/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/tools/virtual-filesystem/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/tools/virtual-filesystem/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/tools/tool-filtering/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/tools/tool-filtering/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/tools/skills/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/tools/skills/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/tools/no-tools/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/tools/no-tools/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/tools/mcp-servers/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/tools/mcp-servers/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/tools/custom-agents/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/tools/custom-agents/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/sessions/streaming/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/sessions/streaming/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/sessions/session-resume/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/sessions/session-resume/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/sessions/infinite-sessions/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/sessions/infinite-sessions/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/sessions/concurrent-sessions/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/sessions/concurrent-sessions/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/prompts/system-message/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/prompts/system-message/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/prompts/reasoning-effort/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/prompts/reasoning-effort/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/prompts/attachments/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/prompts/attachments/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/modes/minimal/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/modes/minimal/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/modes/default/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/modes/default/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/callbacks/user-input/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/callbacks/user-input/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/callbacks/permissions/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/callbacks/permissions/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/callbacks/hooks/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/callbacks/hooks/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/bundling/fully-bundled/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/bundling/fully-bundled/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
test/scenarios/auth/gh-app/go/main.go	Updates scenario client options to use `GitHubToken`.
test/scenarios/auth/gh-app/csharp/Program.cs	Updates scenario client options to use `GitHubToken`.
go/types.go	Renames exported `ClientOptions` field and updates comments to `GitHubToken`.
go/internal/e2e/testharness/context.go	Updates e2e harness client options to use `GitHubToken`.
go/client_test.go	Updates auth option tests and expected messages to `GitHubToken`.
go/client.go	Updates auth validation/env wiring to use `GitHubToken` naming.
go/README.md	Updates documentation to reference `GitHubToken`.
dotnet/test/Harness/E2ETestContext.cs	Updates e2e harness client options to use `GitHubToken`.
dotnet/test/CloneTests.cs	Updates clone coverage to assert `GitHubToken`.
dotnet/test/ClientTests.cs	Updates auth option tests to `GitHubToken`.
dotnet/src/Types.cs	Renames `CopilotClientOptions` property and clone logic to `GitHubToken`.
dotnet/src/Client.cs	Updates auth validation/env wiring to use `GitHubToken` naming.
dotnet/README.md	Updates documentation to reference `GitHubToken`.

go/types.go

dotnet/src/Types.cs

Use PermissionRequest and PermissionRequestResult types instead of plain dict to fix ty type checker errors from stricter enforcement. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-02-23T12:22:18Z

Cross-SDK Consistency Review ✅

Thank you for fixing the GitHub brand casing! I've reviewed this PR for consistency across all four SDK implementations.

✅ Correct Language-Specific Casing

The PR correctly maintains language-appropriate naming conventions:

TypeScript: githubToken (camelCase) - already correct ✅
Python: github_token (snake_case) - already correct ✅
Go: GithubToken → GitHubToken (PascalCase for exported fields) ✅
.NET: GithubToken → GitHubToken (PascalCase for public properties) ✅

⚠️ Minor Inconsistency: Backward Compatibility

There's a small difference in how Go and .NET handle backward compatibility:

.NET (commit 03acc9b): Provides an [Obsolete] property alias:

[Obsolete("Use GitHubToken instead.", error: false)]
public string? GithubToken
{
    get => GitHubToken;
    set => GitHubToken = value;
}

Go: No backward compatibility mechanism (breaking change for users who set GithubToken in ClientOptions)

Recommendation: While Go's struct fields can't be aliased like C# properties, consider documenting this as a breaking change in the release notes or changelog, since users who explicitly set GithubToken will get compilation errors after upgrading. Given that:

The SDK is still in preview (v0.1.x)
GithubToken was only introduced ~25 days ago (Jan 29)
Go modules use semantic versioning where pre-1.0 versions accept breaking changes

This is likely acceptable, but it should be clearly communicated to users.

Python Session Change

The python/copilot/session.py change (adding type hints to _handle_permission_request) appears to be an unrelated improvement and doesn't affect cross-SDK consistency for the GitHub token casing fix.

Overall: The changes maintain excellent cross-SDK consistency while respecting each language's conventions. Nice work! 🎉

AI generated by SDK Consistency Review Agent

SteveSandersonMS requested a review from a team as a code owner February 23, 2026 12:09

Copilot AI review requested due to automatic review settings February 23, 2026 12:09

Copilot started reviewing on behalf of SteveSandersonMS February 23, 2026 12:10 View session

feat(dotnet): add [Obsolete] GithubToken property for backward compat…

03acc9b

…ibility Adds a deprecated GithubToken property that forwards to GitHubToken, allowing existing consumers to migrate without breaking changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI reviewed Feb 23, 2026

View reviewed changes

go/types.go Show resolved Hide resolved

dotnet/src/Types.cs Show resolved Hide resolved

SteveSandersonMS mentioned this pull request Feb 23, 2026

Correct casing of GitHub in types for .NET and Go #453

Closed

fix(python): use typed annotations in _handle_permission_request

f0dcc71

Use PermissionRequest and PermissionRequestResult types instead of plain dict to fix ty type checker errors from stricter enforcement. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

SteveSandersonMS force-pushed the stevesa/fix-github-casing branch from 534ae40 to f0dcc71 Compare February 23, 2026 12:17

SteveSandersonMS merged commit 99c7c52 into main Feb 23, 2026
34 checks passed

SteveSandersonMS deleted the stevesa/fix-github-casing branch February 23, 2026 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: correct 'GithubToken' casing to 'GitHubToken' in .NET and Go#541

fix: correct 'GithubToken' casing to 'GitHubToken' in .NET and Go#541
SteveSandersonMS merged 3 commits intomainfrom
stevesa/fix-github-casing

SteveSandersonMS commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Conversation

SteveSandersonMS commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 23, 2026

Cross-SDK Consistency Review ✅

✅ Correct Language-Specific Casing

⚠️ Minor Inconsistency: Backward Compatibility

Python Session Change

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant