Skip to content

Reduce shutdown latency by parallelizing session destruction #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AkCodes23 wants to merge 3 commits into from
+15 −6
Closed

Reduce shutdown latency by parallelizing session destruction #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54981d4
⚡ Bolt: Parallelize session destruction in Node.js SDK
google-labs-jules[bot] Feb 6, 2026
e436065
Merge pull request #1 from AkCodes23/bolt-parallel-stop-nodejs-138360…
AkCodes23 Feb 7, 2026
52c48f1
Merge branch 'github:main' into main
AkCodes23 Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2025-05-15 - [Sequential session destruction in SDKs]
**Learning:** All Copilot SDKs (Node.js, Python, Go, .NET) were initially implementing session destruction sequentially during client shutdown. This leads to a linear increase in shutdown time as the number of active sessions grows, especially when individual destructions involve retries and backoff.
**Action:** Parallelize session cleanup using language-specific concurrency primitives (e.g., `Promise.all` in Node.js, `asyncio.gather` in Python, `Task.WhenAll` in .NET, or WaitGroups/Channels in Go) to ensure shutdown time remains constant and minimal.
Comment on lines +1 to +3
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn’t appear to be any repo integration or references to the new .jules/ directory (no mentions in docs/CI/config). If this is intended as internal notes, it may be better to keep it out of the shipped repo (e.g., add to .gitignore) or move the content into an existing documentation location (like docs/ or CONTRIBUTING.md) where contributors will find it.

Copilot uses AI. Check for mistakes.
18 changes: 12 additions & 6 deletions nodejs/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,8 @@ export class CopilotClient {
async stop(): Promise<Error[]> {
const errors: Error[] = [];

// Destroy all active sessions with retry logic
for (const session of this.sessions.values()) {
// Destroy all active sessions in parallel with retry logic
const sessionPromises = Array.from(this.sessions.values()).map(async (session) => {
const sessionId = session.sessionId;
let lastError: Error | null = null;
Comment on lines +301 to 304
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Array.from(this.sessions.values()) snapshots the sessions at the start of stop(). If a session is created/resumed while stop() is running, it won’t be destroyed but will still be removed by this.sessions.clear(), which can skip session.destroy() cleanup (and differs from the previous live Map iteration behavior). Consider blocking session creation while stopping (e.g., a stopping flag/state checked in createSession/resumeSession) or draining the map as you schedule destructions so sessions added during shutdown are either rejected or deterministically cleaned up.

Copilot uses AI. Check for mistakes.
Copy link
Author

@AkCodes23 AkCodes23 Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback


Comment on lines +301 to 305
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s no direct unit test coverage for the updated shutdown behavior (parallel destruction + error aggregation). Adding a focused test for stop() (e.g., multiple mock sessions with controlled destroy() delays/failures) would help ensure it still waits for all destructions, returns all per-session errors, and only clears this.sessions after completion.

Copilot uses AI. Check for mistakes.
Expand All @@ -321,12 +321,18 @@ export class CopilotClient {
}

if (lastError) {
errors.push(
new Error(
`Failed to destroy session ${sessionId} after 3 attempts: ${lastError.message}`
)
return new Error(
`Failed to destroy session ${sessionId} after 3 attempts: ${lastError.message}`
);
}
return null;
});

const results = await Promise.all(sessionPromises);
for (const result of results) {
if (result instanceof Error) {
errors.push(result);
}
}
this.sessions.clear();

Expand Down
Loading