Skip to content

C++: Add MaD summaries for shared_ptr, unique_ptr, and weak_ptr. #22198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MathiasVP wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

C++: Add MaD summaries for shared_ptr, unique_ptr, and weak_ptr. #22198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions cpp/ql/lib/ext/std.shared_ptr.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
extensions:
- addsTo:
pack: codeql/cpp-all
extensible: summaryModel
data: # namespace, type, subtypes, name, signature, ext, input, output, kind, provenance
- ["std", "shared_ptr<T>", True, "shared_ptr", "(T *)", "", "Argument[*@0]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "shared_ptr<T>", True, "shared_ptr<Y>", "(Y *)", "", "Argument[*@0]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "shared_ptr<T>", True, "shared_ptr<Y,D>", "(Y *,D)", "", "Argument[*@0]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "shared_ptr<T>", True, "shared_ptr<Y,D,A>", "(Y *,D,A)", "", "Argument[*@0]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "shared_ptr<T>", True, "shared_ptr<Y>", "(const shared_ptr &,T *)", "", "Argument[*@1]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "shared_ptr<T>", True, "shared_ptr<Y>", "(shared_ptr &&,T *)", "", "Argument[*@1]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "shared_ptr", True, "shared_ptr", "(const shared_ptr &)", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
- ["std", "shared_ptr", True, "shared_ptr", "(shared_ptr &&)", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
- ["std", "shared_ptr<T>", True, "shared_ptr<Y>", "(const weak_ptr &)", "", "Argument[*0].Element[@]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "shared_ptr<T>", True, "shared_ptr<Y,D>", "(unique_ptr &&)", "", "Argument[*0].Element[@]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "shared_ptr", True, "operator=", "(const shared_ptr &)", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
- ["std", "shared_ptr", True, "operator=", "(const shared_ptr &)", "", "Argument[*0]", "ReturnValue[*]", "value", "manual"]
- ["std", "shared_ptr", True, "operator=", "(shared_ptr &&)", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
- ["std", "shared_ptr", True, "operator=", "(shared_ptr &&)", "", "Argument[*0]", "ReturnValue[*]", "value", "manual"]
- ["std", "shared_ptr", True, "operator=", "(unique_ptr &&)", "", "Argument[*0].Element[@]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "shared_ptr", True, "operator=", "(unique_ptr &&)", "", "Argument[*0].Element[@]", "ReturnValue[*].Element[@]", "value", "manual"]
- ["std", "shared_ptr", True, "get", "", "", "Argument[-1].Element[@]", "ReturnValue[*@]", "value", "manual"]
- ["std", "shared_ptr", True, "operator*", "", "", "Argument[-1].Element[@]", "ReturnValue[*@]", "value", "manual"]
- ["std", "shared_ptr", True, "operator->", "", "", "Argument[-1].Element[@]", "ReturnValue[*@]", "value", "manual"]
- ["std", "shared_ptr", True, "operator[]", "", "", "Argument[-1].Element[@]", "ReturnValue[*@]", "value", "manual"]
- ["std", "shared_ptr", True, "reset", "", "", "Argument[*@0]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "shared_ptr", True, "swap", "", "", "Argument[-1]", "Argument[*0]", "value", "manual"]
- ["std", "shared_ptr", True, "swap", "", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
- ["std", "", False, "swap", "(shared_ptr &,shared_ptr &)", "", "Argument[*0].Element[@]", "Argument[*1].Element[@]", "value", "manual"]
- ["std", "", False, "swap", "(shared_ptr &,shared_ptr &)", "", "Argument[*1].Element[@]", "Argument[*0].Element[@]", "value", "manual"]
- ["std", "", False, "static_pointer_cast<T,U>", "(const shared_ptr &)", "", "Argument[*0]", "ReturnValue", "value", "manual"]
- ["std", "", False, "static_pointer_cast<T,U>", "(shared_ptr &&)", "", "Argument[*0]", "ReturnValue", "value", "manual"]
- ["std", "", False, "dynamic_pointer_cast<T,U>", "(const shared_ptr &)", "", "Argument[*0]", "ReturnValue", "value", "manual"]
- ["std", "", False, "dynamic_pointer_cast<T,U>", "(shared_ptr &&)", "", "Argument[*0]", "ReturnValue", "value", "manual"]
- ["std", "", False, "const_pointer_cast<T,U>", "(const shared_ptr &)", "", "Argument[*0]", "ReturnValue", "value", "manual"]
- ["std", "", False, "const_pointer_cast<T,U>", "(shared_ptr &&)", "", "Argument[*0]", "ReturnValue", "value", "manual"]
- ["std", "", False, "reinterpret_pointer_cast<T,U>", "(const shared_ptr &)", "", "Argument[*0]", "ReturnValue", "value", "manual"]
- ["std", "", False, "reinterpret_pointer_cast<T,U>", "(shared_ptr &&)", "", "Argument[*0]", "ReturnValue", "value", "manual"]
25 changes: 25 additions & 0 deletions cpp/ql/lib/ext/std.unique_ptr.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
extensions:
- addsTo:
pack: codeql/cpp-all
extensible: summaryModel
data: # namespace, type, subtypes, name, signature, ext, input, output, kind, provenance
- ["std", "unique_ptr<T,D>", True, "unique_ptr", "(T *)", "", "Argument[*@0]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "unique_ptr<T,D>", True, "unique_ptr", "(T *,const D &)", "", "Argument[*@0]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "unique_ptr<T,D>", True, "unique_ptr", "(T *,D &)", "", "Argument[*@0]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "unique_ptr<T,D>", True, "unique_ptr", "(T *,D &&)", "", "Argument[*@0]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "unique_ptr<T,D>", True, "unique_ptr", "(T *,const D &)", "", "Argument[*@0]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "unique_ptr<T,D>", True, "unique_ptr", "(T *,D &)", "", "Argument[*@0]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "unique_ptr<T,D>", True, "unique_ptr", "(T *,D &&)", "", "Argument[*@0]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "unique_ptr", True, "unique_ptr", "(unique_ptr &&)", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
- ["std", "unique_ptr", True, "operator=", "(unique_ptr &&)", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
- ["std", "unique_ptr", True, "operator=", "(unique_ptr &&)", "", "Argument[*0]", "ReturnValue[*]", "value", "manual"]
- ["std", "unique_ptr", True, "get", "", "", "Argument[-1].Element[@]", "ReturnValue[*@]", "value", "manual"]
- ["std", "unique_ptr", True, "operator*", "", "", "Argument[-1].Element[@]", "ReturnValue[*@]", "value", "manual"]
- ["std", "unique_ptr", True, "operator->", "", "", "Argument[-1].Element[@]", "ReturnValue[*@]", "value", "manual"]
- ["std", "unique_ptr", True, "operator[]", "", "", "Argument[-1].Element[@]", "ReturnValue[*@]", "value", "manual"]
- ["std", "unique_ptr", True, "release", "", "", "Argument[-1].Element[@]", "ReturnValue[*@]", "value", "manual"]
- ["std", "unique_ptr", True, "reset", "(T *)", "", "Argument[*@0]", "Argument[-1].Element[@]", "value", "manual"]
- ["std", "unique_ptr", True, "swap", "", "", "Argument[-1]", "Argument[*0]", "value", "manual"]
- ["std", "unique_ptr", True, "swap", "", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
- ["std", "", False, "swap", "(unique_ptr &,unique_ptr &)", "", "Argument[*0].Element[@]", "Argument[*1].Element[@]", "value", "manual"]
- ["std", "", False, "swap", "(unique_ptr &,unique_ptr &)", "", "Argument[*1].Element[@]", "Argument[*0].Element[@]", "value", "manual"]
19 changes: 19 additions & 0 deletions cpp/ql/lib/ext/std.weak_ptr.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
extensions:
- addsTo:
pack: codeql/cpp-all
extensible: summaryModel
data: # namespace, type, subtypes, name, signature, ext, input, output, kind, provenance
- ["std", "weak_ptr", True, "weak_ptr", "(const weak_ptr &)", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
- ["std", "weak_ptr", True, "weak_ptr", "(weak_ptr &&)", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
- ["std", "weak_ptr<T>", True, "weak_ptr<Y>", "(const shared_ptr &)", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
- ["std", "weak_ptr", True, "operator=", "(const weak_ptr &)", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
- ["std", "weak_ptr", True, "operator=", "(const weak_ptr &)", "", "Argument[*0]", "ReturnValue[*]", "value", "manual"]
- ["std", "weak_ptr", True, "operator=", "(weak_ptr &&)", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
- ["std", "weak_ptr", True, "operator=", "(weak_ptr &&)", "", "Argument[*0]", "ReturnValue[*]", "value", "manual"]
- ["std", "weak_ptr", True, "operator=", "(const shared_ptr &)", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
- ["std", "weak_ptr", True, "operator=", "(const shared_ptr &)", "", "Argument[*0]", "ReturnValue[*]", "value", "manual"]
- ["std", "weak_ptr", True, "lock", "", "", "Argument[-1]", "ReturnValue", "value", "manual"]
- ["std", "weak_ptr", True, "swap", "", "", "Argument[-1]", "Argument[*0]", "value", "manual"]
- ["std", "weak_ptr", True, "swap", "", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
- ["std", "", False, "swap", "(weak_ptr &,weak_ptr &)", "", "Argument[*0]", "Argument[*1]", "value", "manual"]
- ["std", "", False, "swap", "(weak_ptr &,weak_ptr &)", "", "Argument[*1]", "Argument[*0]", "value", "manual"]
8 changes: 8 additions & 0 deletions cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowDispatch.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,14 @@ private predicate qualifierSourceImpl(RelevantNode n, Class c) {
convert.getDerivedClass() = c and
c.getABaseClass*().getAMemberFunction().isVirtual()
)
// or
// exists(Function f |
// f = n.(DataFlowPrivate::OutNode).getCall().getStaticCallSourceTarget() and
// n.(DataFlowPrivate::OutNode).getReturnKind().isNormalReturn() and
// n.(DataFlowPrivate::OutNode).getReturnKind().getIndirectionIndex() = 1 and
// f.hasGlobalOrStdOrBslName("make_unique") and
// c = f.(FunctionTemplateInstantiation).getTemplateArgument(0)
// )
}

private module TrackVirtualDispatch<methodDispatchSig/1 virtualDispatch0> {
Expand Down
13 changes: 0 additions & 13 deletions cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaImplCommon.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,19 +174,6 @@ private class PointerOrArrayOrReferenceTypeIndirection extends Indirection insta
}
}

private class PointerWrapperTypeIndirection extends Indirection instanceof PointerWrapper {
PointerWrapperTypeIndirection() { baseType = PointerWrapper.super.getBaseType() }

override predicate isAdditionalDereference(Instruction deref, Operand address) {
exists(CallInstruction call |
operandForFullyConvertedCall(getAUse(deref), call) and
this =
call.getStaticCallTarget().(Function).getClassAndName(["operator*", "operator->", "get"]) and
address = call.getThisArgumentOperand()
)
}
}

private module IteratorIndirections {
import semmle.code.cpp.models.interfaces.Iterator as Interfaces
import semmle.code.cpp.models.implementations.Iterator as Iterator
Expand Down
Loading