Skip to content

Analyze Go ControlFlowGraph expected outputs#21904

Closed
Copilot wants to merge 1 commit into
mainfrom
copilot/controlflow-graph-analysis
Closed

Analyze Go ControlFlowGraph expected outputs#21904
Copilot wants to merge 1 commit into
mainfrom
copilot/controlflow-graph-analysis

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 28, 2026

The Go ControlFlowGraph .expected files were reviewed against main to check for CFG shape regressions from the old control-flow library.

  • Expected-output comparison

    • Compared ControlFlowNode_getASuccessor.expected and NoretFunctions.expected with main.
    • Found no semantic CFG-shape differences requiring code or test updates.
  • Result

    • No repository changes were needed; the current expected outputs already match main.
Original prompt

Look at the .expected files in go/ql/test/library-tests/semmle/go/controlflow/ControlFlowGraph/. Compare them to what they are on main, with the old control flow library. Do any of the current control flow graphs seem wrong? Make a list of issues that need to be addressed. Changes of names of nodes, or the number of nodes, are not important - it's the shape of the control flow graph that is important, and whether all aspects of control flow are captured correctly.

Created from VS Code.

Copilot AI changed the title [WIP] Analyze control flow graphs for discrepancies Analyze Go ControlFlowGraph expected outputs May 28, 2026
Copilot AI requested a review from owen-mc May 28, 2026 12:24
@owen-mc owen-mc closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants