Skip to content

C++: Disable cpp/implicit-function-declaration on build mode none databases #21553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoffw0 merged 10 commits into from
Apr 10, 2026
Merged

C++: Disable cpp/implicit-function-declaration on build mode none databases #21553

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5a77128
C++: Disable cpp/implicit-function-declaration on BMN databases.
geoffw0 Mar 23, 2026
39056e4
C++: Change note.
geoffw0 Mar 23, 2026
bb9873d
C++: Increase the query precision to high.
geoffw0 Mar 27, 2026
50681a3
C++: Add note to the .qhelp.
geoffw0 Mar 27, 2026
4f3108c
C++: Update change note.
geoffw0 Mar 27, 2026
a9cce1c
C++: Undo increasing query precision.
geoffw0 Mar 27, 2026
2d02056
C++: Second change note.
geoffw0 Apr 2, 2026
e83658e
C++: Upgrade query precision.
geoffw0 Apr 2, 2026
9eabfc5
Update cpp/ql/src/Likely Bugs/Underspecified Functions/ImplicitFuncti…
geoffw0 Apr 2, 2026
56af9a8
Update cpp/ql/src/Likely Bugs/Underspecified Functions/ImplicitFuncti…
geoffw0 Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cpp/ql/src/Likely Bugs/Underspecified Functions/ImplicitFunctionDeclaration.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ import TooFewArguments
import TooManyArguments
import semmle.code.cpp.commons.Exclusions

/*
* This query is not compatible with build mode: none databases, and has
* no results on those databases.
Comment thread
geoffw0 marked this conversation as resolved.
Outdated
Comment thread
geoffw0 marked this conversation as resolved.
Outdated
*/

predicate locInfo(Locatable e, File file, int line, int col) {
e.getFile() = file and
e.getLocation().getStartLine() = line and
Expand All @@ -39,6 +44,7 @@ predicate isCompiledAsC(File f) {
from FunctionDeclarationEntry fdeIm, FunctionCall fc
where
isCompiledAsC(fdeIm.getFile()) and
not any(Compilation c).buildModeNone() and
Comment thread
geoffw0 marked this conversation as resolved.
not isFromMacroDefinition(fc) and
fdeIm.isImplicit() and
sameLocation(fdeIm, fc) and
Expand Down
4 changes: 4 additions & 0 deletions cpp/ql/src/change-notes/2026-03-23-implicit-function-declaration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The "Implicit function declaration" (`cpp/implicit-function-declaration`) query no longer produces results on `build mode: none` databases. These results were found to be very noisy and fundamentally imprecise in this mode.
Loading