Skip to content

Rust: Update split_off models #21376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geoffw0 wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −18
Open

Rust: Update split_off models #21376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
478f56b
Rust: Move the existing 'alloc' neutral models into alloc.model.yml.
geoffw0 Feb 26, 2026
f2dc585
Rust: Convert split_off QL-defined barrier to a neutral model (which …
geoffw0 Feb 26, 2026
d81b9aa
Merge branch 'main' into splitoff2
geoffw0 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion rust/ql/lib/codeql/rust/frameworks/stdlib/alloc.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,14 @@ extensions:
- ["<alloc::string::String as core::ops::arith::Add>::add", "Argument[0].Reference", "ReturnValue", "taint", "manual"]
# Vec
- ["alloc::vec::from_elem", "Argument[0]", "ReturnValue.Element", "value", "manual"]
- ["<alloc::vec::Vec as core::ops::deref::Deref>::deref", "Argument[self].Reference.Element", "ReturnValue.Reference.Element", "value", "manual"]
- ["<alloc::vec::Vec as core::ops::deref::Deref>::deref", "Argument[self].Reference.Element", "ReturnValue.Reference.Element", "value", "manual"]
- addsTo:
pack: codeql/rust-all
extensible: neutralModel
data:
- ["<alloc::vec::Vec as core::convert::From>::from", "sink", "manual"]
- ["<alloc::collections::vec_deque::VecDeque as core::convert::From>::from", "sink", "manual"]
- ["<alloc::sync::Arc as core::convert::From>::from", "sink", "manual"]
- ["<alloc::rc::Rc as core::convert::From>::from", "sink", "manual"]
- ["<alloc::string::String>::split_off", "sink", "manual"]
- ["<alloc::vec::Vec>::split_off", "sink", "manual"]
4 changes: 0 additions & 4 deletions rust/ql/lib/codeql/rust/frameworks/stdlib/core.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,7 @@ extensions:
extensible: neutralModel
data:
- ["<core::option::Option>::map", "sink", "manual"]
- ["<alloc::vec::Vec as core::convert::From>::from", "sink", "manual"]
- ["<alloc::collections::vec_deque::VecDeque as core::convert::From>::from", "sink", "manual"]
- ["<std::io::error::Error as core::convert::From>::from", "sink", "manual"]
- ["<alloc::sync::Arc as core::convert::From>::from", "sink", "manual"]
- ["<alloc::rc::Rc as core::convert::From>::from", "sink", "manual"]
- addsTo:
pack: codeql/rust-all
extensible: excludeFieldTaintStep
Expand Down
13 changes: 0 additions & 13 deletions rust/ql/lib/codeql/rust/security/UncontrolledAllocationSizeExtensions.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,17 +63,4 @@ module UncontrolledAllocationSize {
branch = false
)
}

/**
* A barrier for uncontrolled allocation size flow into particular functions.
*/
private class ModeledBarrier extends Barrier {
ModeledBarrier() {
exists(MethodCall c |
c.getStaticTarget().getCanonicalPath() =
["<alloc::string::String>::split_off", "<alloc::vec::Vec>::split_off"] and
this.asExpr() = c.getAnArgument()
)
}
}
}