Skip to content

JS: Emit variables for 'this' #21369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
asgerf wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Draft

JS: Emit variables for 'this' #21369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions javascript/extractor/src/com/semmle/js/extractor/ASTExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,6 +819,7 @@ public Label visit(Program nd, Context c) {
// add all declared global (or module-scoped) names, both non-lexical and lexical
scopeManager.addNames(scopeManager.collectDeclaredNames(nd, isStrict, false, DeclKind.none));
scopeManager.addNames(scopeManager.collectDeclaredNames(nd, isStrict, true, DeclKind.none));
scopeManager.addVariables("this");

visitAll(nd.getBody(), toplevelLabel);

Expand Down Expand Up @@ -1070,6 +1071,9 @@ private void extractFunction(IFunction nd, Label key) {

scopeManager.enterScope((Node) nd);
scopeManager.addNames(locals);
if (!(nd instanceof ArrowFunctionExpression)) {
scopeManager.addVariables("this");
}

// The name of a function expression binds to its own scope.
if (nd.getId() != null && nd instanceof AFunctionExpression) {
Expand Down