Rust: yet another tentative fix to test flakiness#19836
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to resolve test flakiness by updating the pinned libc version and corresponding expected outputs in the CWE-770 path resolution consistency tests.
- Bump
libcdependency to version 0.2.174 for qltest - Adjust expected crate version lines from 0.2.173 → 0.2.172 in the consistency test
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rust/ql/test/query-tests/security/CWE-770/options.yml | Updated the libc version in qltest_dependencies. |
| rust/ql/test/query-tests/security/CWE-770/CONSISTENCY/PathResolutionConsistency.expected | Modified expected crate version references in output. |
Comments suppressed due to low confidence (1)
rust/ql/test/query-tests/security/CWE-770/options.yml:3
- The consistency test expects two versions of
libc(0.2.172 and 0.2.174), but only 0.2.174 is declared here. Either addlibc = { version = "0.2.172" }toqltest_dependenciesor update the expected file to match a single version.
- libc = { version = "0.2.174" }
rust/ql/test/query-tests/security/CWE-770/CONSISTENCY/PathResolutionConsistency.expected
Show resolved
Hide resolved
aibaars
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.