Swift: Support new Swift 6.1 AST elements#19420
Merged
Conversation
jketema
force-pushed
the
jketema/swift-6.1-contructs
branch
from
5dc41fe to
8ffe78c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
swift/ql/lib/codeql/swift/elements/type/internal/BuiltinFixedArrayTypeImpl.qll
Fixed
Show fixed
Hide fixed
jketema
force-pushed
the
jketema/swift-6.1-contructs
branch
2 times, most recently
from
ebaebd1 to
b8e7f5d
Compare
jketema
force-pushed
the
jketema/swift-6.1-contructs
branch
from
b8e7f5d to
95ac458
Compare
jketema
commented
May 2, 2025
Comment on lines
+1
to
+2
| | type_value_exprs.swift:4:13:4:13 | TypeValueExpr | hasType: | yes | getTypeRepr: | type_value_exprs.swift:4:13:4:13 | (no string representation) | | ||
| | type_value_exprs.swift:5:13:5:13 | TypeValueExpr | hasType: | yes | getTypeRepr: | type_value_exprs.swift:5:13:5:13 | (no string representation) | |
Contributor
Author
There was a problem hiding this comment.
I'm not sure why I'm seeing (no string representation) here
Contributor
There was a problem hiding this comment.
yeah, that is odd, I thought there was a default implementation in place (using the primary class). We can look at it in a follow up I think
redsun82
approved these changes
May 2, 2025
Contributor
redsun82
left a comment
redsun82
left a comment
There was a problem hiding this comment.
Very nice!
I think the "no string representation" might be worth a bit of investigation, but I don't think it's blocking for this PR 👍
Contributor
Author
Great. In that case I merge this PR once DCA looks ok, and I'll create a follow-up issue for the "no string representation". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.