C#: Add cs/equality-on-floats to the Code Quality suite.#19396
Merged
michaelnebel merged 4 commits intogithub:mainfrom Apr 29, 2025
Merged
C#: Add cs/equality-on-floats to the Code Quality suite.#19396michaelnebel merged 4 commits intogithub:mainfrom
cs/equality-on-floats to the Code Quality suite.#19396michaelnebel merged 4 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR increases the precision of the cs/equality-on-floats query from medium to high by updating the change notes.
- Introduces a new change note file outlining the precision update
- Categorizes the change as a minor analysis update
Files not reviewed (3)
- csharp/ql/integration-tests/posix/query-suite/csharp-code-quality.qls.expected: Language not supported
- csharp/ql/src/Likely Bugs/EqualityCheckOnFloats.ql: Language not supported
- csharp/ql/src/codeql-suites/csharp-code-quality.qls: Language not supported
hvitved
approved these changes
Apr 29, 2025
Contributor
Author
|
DCA looks good, but the experiment failed to start for ASP.NET (traced). I tried running the query locally for this repo and the alerts look good (and there doesn't appear to be any issues with performance either). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The precision of the query has been increased to high. Even though comparing floats in many cases yield correct results, it should generally be avoided. If exact comparison is needed,
decimalshould be used instead.