Conversation
geoffw0
added
no-change-note-required
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (10)
- rust/ql/consistency-queries/SsaConsistency.ql: Language not supported
- rust/ql/integration-tests/hello-project/summary.expected: Language not supported
- rust/ql/integration-tests/hello-workspace/summary.cargo.expected: Language not supported
- rust/ql/integration-tests/hello-workspace/summary.rust-project.expected: Language not supported
- rust/ql/src/queries/diagnostics/SsaConsistencyCounts.ql: Language not supported
- rust/ql/src/queries/summary/Stats.qll: Language not supported
- rust/ql/test/query-tests/diagnostics/SsaConsistencyCounts.expected: Language not supported
- rust/ql/test/query-tests/diagnostics/SsaConsistencyCounts.qlref: Language not supported
- rust/ql/test/query-tests/diagnostics/SummaryStatsReduced.expected: Language not supported
- shared/ssa/codeql/ssa/Ssa.qll: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1 @@ | |||
| queries/diagnostics/SsaConsistencyCounts.ql | |||
Check warning
Code scanning / CodeQL
Query test without inline test expectations Warning test
There was a problem hiding this comment.
It's a diagnostic query.
| * @id rust/diagnostics/ssa-consistency-counts | ||
| */ | ||
|
|
||
| private import codeql.rust.dataflow.internal.SsaImpl as SsaImpl |
There was a problem hiding this comment.
Perhaps just private import codeql.rust.dataflow.internal.SsaImpl::Consistency?
There was a problem hiding this comment.
That exact import causes all the query predicates in SsaImpl::Consistency to apply, breaking this query - but private import codeql.rust.dataflow.internal.SsaImpl::Consistency as SsaConsistency works and is more precise.
I've updated the query.
2 participants
Provide SSA inconsistency counts:
rust/diagnostics/ssa-consistency(which has been given metadata).rust/diagnostics/ssa-consistency-counts.rust/summary/summary-statistics(via changes inStats.qll). This data will be used by the DCA report.This required adding a predicate
getInconsistencyCountsto the sharedSSA.qll, similar to the one we already have for data flow. This shouldn't be controversial as no existing shared behaviour is changed, but I'm open to suggestions / comments representing all interests of course.