C#: Accept file sync mismatch for C# testfiles.

[michaelnebel]

To better allow inline expectations testing, we consider test files to be identical (or equivalent), if they are "the same" modulo comments.

[Copilot]

Pull Request Overview

This PR updates C# test file handling by allowing test file comparisons to ignore comment differences. Key changes include:

• Removing a duplicate (and buggy) method in ConstantIfCondition.cs while providing a similar test case in ConstantConditionBad.cs.
• Adding a test case for API abuse with missing Dispose calls in NoDisposeCallOnLocalIDisposableBad.cs.
• Enhancing the sync-files.py script to support file equivalence modulo comment differences by introducing new functions and modifying check_group logic.

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
csharp/ql/test/query-tests/Bad Practices/Control-Flow/ConstantCondition/ConstantIfCondition.cs	Removed a redundant Max method containing a bug.
csharp/ql/test/query-tests/Bad Practices/Control-Flow/ConstantCondition/ConstantConditionBad.cs	Added a test file that intentionally uses a buggy Max method.
csharp/ql/test/query-tests/API Abuse/NoDisposeCallOnLocalIDisposableBad.cs	Introduced a test case highlighting missing Dispose call via an alert.
csharp/ql/test/query-tests/API Abuse/NoDisposeCallOnLocalIDisposable.cs	Removed duplicate faulty implementation of Bad class.
config/sync-files.py	Modified file synchronization logic to consider files equivalent when differences are limited to comments.

Files not reviewed (2)

• csharp/ql/test/query-tests/API Abuse/NoDisposeCallOnLocalIDisposable/NoDisposeCallOnLocalIDisposable.expected: Language not supported
• csharp/ql/test/query-tests/Bad Practices/Control-Flow/ConstantCondition/ConstantCondition.expected: Language not supported

Comments suppressed due to low confidence (1)

config/sync-files.py:73

• The parameter name 'accept_prefix' in check_group shadows the global function 'accept_prefix', which may cause confusion. Consider renaming the parameter to something like 'use_comment_check' or 'ignore_comments' for improved clarity.

def check_group(group_name, files, master_file_picker, emit_error, accept_prefix):

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more