C#: Update PreSSA to reference the new use-use predicates.#19178
C#: Update PreSSA to reference the new use-use predicates.#19178aschackmull merged 1 commit intogithub:mainfrom
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- csharp/ql/lib/semmle/code/csharp/controlflow/internal/PreSsa.qll: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
hvitved
left a comment
There was a problem hiding this comment.
LGTM (but let's wait for DCA to come back clean before merging).
|
Dca looks fine. I checked the single new alert - it's technically true, the assigned value is never read, but it relies on knowing that a |
This adds a few tuples to the updated predicates. Spot-checking the additions for
adjacentReadPairSameVarall look correct. The differences forgetAFirstReadall had to do withrefvariables, and I couldn't quite make sense of them, but there weren't that many, and I think the new version ought to be more correct.