Port js/TaintedPath tests to post-process and don't expect 'Source' tag on same line#18643
Closed
asgerf wants to merge 11 commits intogithub:mainfrom
Closed
Port js/TaintedPath tests to post-process and don't expect 'Source' tag on same line#18643asgerf wants to merge 11 commits intogithub:mainfrom
asgerf wants to merge 11 commits intogithub:mainfrom
Conversation
Simply converts the comments as they are, regardless of actual query output
Unfortunately this also triggers a reordering of result sets in the output.
Previously the Source tag was required if the source and alert did not have the exact same location. This relaxes the restriction to being on the same line. Note that in order to be "on the same line" both start and end lines have to match. It's still possible for a given line to expect both Alert and Source tags, in case the source pairs up with another alert on a different line.
Contributor
Author
|
Superseded by another PR since there are already test cases able to exercise the new behaviour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two changes: a change to the post-processing test library, and one JS test case to exercise the new behaviour. And also some updates to other tests.
The post-processing test change is that the
Sourcetag is no longer expected if the source and alert location are on the same line. Previously they had to have the exact same location in order forSourceto be omitted. See d349b51 and c5545f0.The TaintedPath test is ported from JavaScript's old inline test to being post-processed, and demonstrates how it is affected by the change to the post-processing library.