Skip to content

Commit 76d8ae8

Browse files
owen-mcowen-mc
committed
Add MISSING: tag
1 parent 843ac7c commit 76d8ae8

87 files changed

Lines changed: 284 additions & 284 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎cpp/ql/test/examples/BadLocking/UnintendedDeclaration.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ class MyTestClass
8686

8787
void test7()
8888
{
89-
Lock<Mutex>(memberMutex); // BAD (creates an uninitialized variable called `memberMutex`, probably not intended) [NOT DETECTED]
89+
Lock<Mutex>(memberMutex); // $ MISSING: Alert // BAD (creates an uninitialized variable called `memberMutex`, probably not intended) [NOT DETECTED]
9090

9191
// ...
9292
}

‎cpp/ql/test/experimental/query-tests/Security/CWE/CWE-020/NoCheckBeforeUnsafePutUser/test.cpp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ void test1(int p)
1919
{
2020
sys_somesystemcall(&p);
2121

22-
unsafe_put_user(123, &p); // BAD [NOT DETECTED]
22+
unsafe_put_user(123, &p); // $ MISSING: Alert // $ MISSING: Alert // BAD [NOT DETECTED]
2323
}
2424

2525
void test2(int p)
@@ -40,7 +40,7 @@ void test3()
4040

4141
sys_somesystemcall(&v);
4242

43-
unsafe_put_user(123, &v); // BAD [NOT DETECTED]
43+
unsafe_put_user(123, &v); // $ MISSING: Alert // $ MISSING: Alert // BAD [NOT DETECTED]
4444
}
4545

4646
void test4()
@@ -68,7 +68,7 @@ void test5()
6868

6969
sys_somesystemcall(&myData);
7070

71-
unsafe_put_user(123, &(myData.x)); // BAD [NOT DETECTED]
71+
unsafe_put_user(123, &(myData.x)); // $ MISSING: Alert // $ MISSING: Alert // BAD [NOT DETECTED]
7272
}
7373

7474
void test6()

‎cpp/ql/test/experimental/query-tests/Security/CWE/CWE-190/AllocMultiplicationOverflow/test.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ void test()
2424

2525
size_t size2 = x;
2626
size2 *= y;
27-
char *buffer6 = (char *)malloc(size2); // BAD [NOT DETECTED]
27+
char *buffer6 = (char *)malloc(size2); // $ MISSING: Alert // $ MISSING: Alert // BAD [NOT DETECTED]
2828

2929
char *buffer7 = new char[x * 10]; // GOOD
3030
char *buffer8 = new char[x * y]; // $ Alert // BAD

‎cpp/ql/test/experimental/query-tests/Security/CWE/CWE-193/array-access/test.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,6 @@ void test7(int size) {
105105
}
106106

107107
for (char *p = arr; p <= arr + size; p++) {
108-
*p = 0; // BAD [NOT DETECTED]
108+
*p = 0; // $ MISSING: Alert // BAD [NOT DETECTED]
109109
}
110110
}

‎cpp/ql/test/experimental/query-tests/Security/CWE/CWE-200/test3/test.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ int main(int argc, char *argv[])
1010
{
1111
FILE *fp;
1212
char buf[128];
13-
fp = fopen("myFile.txt","r+"); // BAD [NOT DETECTED]
14-
fgets(buf,128,fp);
13+
fp = fopen("myFile.txt","r+"); // $ MISSING: Alert // BAD [NOT DETECTED]
14+
fgets(buf,128,fp);
1515
fprintf(fp,"%s\n","data to file");
1616
fclose(fp);
1717
return 0;

‎cpp/ql/test/experimental/query-tests/Security/CWE/CWE-369/semmle/tests/test.cpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@ int badTestf3(int type, int met) {
5858
is = getSize(type);
5959
switch (met) {
6060
case 1:
61-
if (is >= 0) return 123 / is; // BAD [NOT DETECTED]
61+
if (is >= 0) return 123 / is; // $ MISSING: Alert // BAD [NOT DETECTED]
6262
case 2:
63-
if (0 == is) return 123 / is; // BAD [NOT DETECTED]
63+
if (0 == is) return 123 / is; // $ MISSING: Alert // BAD [NOT DETECTED]
6464
case 3:
6565
if (!is & 123 / is) // $ Alert // BAD
6666
return 123;
@@ -82,7 +82,7 @@ int badTestf3(int type, int met) {
8282
}
8383
if (is != 0) return -1;
8484
if (is == 0) type += 1;
85-
return 123 / is; // BAD [NOT DETECTED]
85+
return 123 / is; // $ MISSING: Alert // BAD [NOT DETECTED]
8686
}
8787

8888
int goodTestf3(int type, int met) {
@@ -223,7 +223,7 @@ int badTestf12(FILE * f) {
223223
int a;
224224
int ret = -1;
225225
a = getc(f);
226-
if (a == 0) ret = 123 / a; // BAD [NOT DETECTED]
226+
if (a == 0) ret = 123 / a; // $ MISSING: Alert // BAD [NOT DETECTED]
227227
return ret;
228228
}
229229

@@ -262,7 +262,7 @@ void badTestf13(int type) {
262262
if (is < 5)
263263
badMySubDiv(type, is); // $ Alert // BAD
264264
if (is < 0)
265-
badMySubDiv(type, is); // BAD [NOT DETECTED]
265+
badMySubDiv(type, is); // $ MISSING: Alert // BAD [NOT DETECTED]
266266
if (is > 5)
267267
badMySubDiv(type, is); // GOOD
268268
if (is == 0)

‎cpp/ql/test/experimental/query-tests/Security/CWE/CWE-377/semmle/tests/test.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ int funcTest3()
3939
FILE *fp;
4040
char filename[80];
4141
strcat(filename, "/tmp/tmp.name");
42-
fp = fopen(filename,"w"); // BAD [NOT DETECTED]
42+
fp = fopen(filename,"w"); // $ MISSING: Alert // BAD [NOT DETECTED]
4343
fprintf(fp,"%s\n","data to file");
4444
fclose(fp);
4545
return 0;

‎cpp/ql/test/experimental/query-tests/Security/CWE/CWE-754/semmle/tests/test.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ int functionWork1b(int retIndex) {
6060
}
6161
int functionWork1_() {
6262
int i;
63-
scanf("%i",&i); // BAD [NOT DETECTED]
63+
scanf("%i",&i); // $ MISSING: Alert // BAD [NOT DETECTED]
6464
if(i<10)
6565
return -1;
6666
return i;

‎cpp/ql/test/query-tests/Best Practices/GuardedFree/test.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ void test6(char *x) {
5252
}
5353

5454
void test7(char *x) {
55-
if (x || x) { // BAD [NOT DETECTED]
55+
if (x || x) { // $ MISSING: Alert // BAD [NOT DETECTED]
5656
free(x);
5757
}
5858
}
@@ -91,7 +91,7 @@ void test10(char *x) {
9191
if (x) free(x);
9292

9393
void test11(char *x) {
94-
TRY_FREE(x) // BAD [NOT DETECTED]
94+
TRY_FREE(x) // $ MISSING: Alert // BAD [NOT DETECTED]
9595
}
9696

9797
bool test12(char *x) {

‎cpp/ql/test/query-tests/Best Practices/Likely Errors/OffsetUseBeforeRangeCheck/test.cpp‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,24 +15,24 @@ void test(char *buffer, int bufferSize)
1515
if ((buffer[i] == 'x') && (i < bufferSize)) {} // $ Alert // BAD
1616

1717
if ((bufferSize > i) && (buffer[i] == 'x')) {} // GOOD
18-
if ((buffer[i] == 'x') && (bufferSize > i)) {} // BAD [NOT DETECTED]
18+
if ((buffer[i] == 'x') && (bufferSize > i)) {} // $ MISSING: Alert // BAD [NOT DETECTED]
1919

2020
if ((i <= bufferSize - 1) && (buffer[i] == 'x')) {} // GOOD
21-
if ((buffer[i] == 'x') && (i <= bufferSize - 1)) {} // BAD [NOT DETECTED]
21+
if ((buffer[i] == 'x') && (i <= bufferSize - 1)) {} // $ MISSING: Alert // BAD [NOT DETECTED]
2222

2323
if ((bufferSize >= i + 1) && (buffer[i] == 'x')) {} // GOOD
24-
if ((buffer[i] == 'x') && (bufferSize >= i + 1)) {} // BAD [NOT DETECTED]
24+
if ((buffer[i] == 'x') && (bufferSize >= i + 1)) {} // $ MISSING: Alert // BAD [NOT DETECTED]
2525

2626
if ((i < bufferSize) && (true) && (buffer[i] == 'x')) {} // GOOD
2727
if ((buffer[i] == 'x') && (true) && (i < bufferSize)) {} // $ Alert // BAD
2828

2929
if ((i < bufferSize - 1) && (buffer[i + 1] == 'x')) {} // GOOD
30-
if ((buffer[i + 1] == 'x') && (i < bufferSize - 1)) {} // BAD [NOT DETECTED]
30+
if ((buffer[i + 1] == 'x') && (i < bufferSize - 1)) {} // $ MISSING: Alert // BAD [NOT DETECTED]
3131

3232
if ((i < bufferSize) && (buffer[i] == 'x') && (i < bufferSize - 1)) {} // GOOD
3333
if ((i < bufferSize) && ((buffer[i] == 'x') && (i < bufferSize - 1))) {} // GOOD
34-
if ((i < bufferSize + 1) && (buffer[i] == 'x') && (i < bufferSize)) {} // BAD [NOT DETECTED]
35-
if ((i < bufferSize + 1) && ((buffer[i] == 'x') && (i < bufferSize))) {} // BAD [NOT DETECTED]
34+
if ((i < bufferSize + 1) && (buffer[i] == 'x') && (i < bufferSize)) {} // $ MISSING: Alert // BAD [NOT DETECTED]
35+
if ((i < bufferSize + 1) && ((buffer[i] == 'x') && (i < bufferSize))) {} // $ MISSING: Alert // BAD [NOT DETECTED]
3636

3737
// look for 'ab'
3838
for (i = 0; i < bufferSize; i++) {

0 commit comments

Comments
 (0)