Add SPURIOUS: tags

Author: owen-mc

cpp/ql/test/experimental/query-tests/Security/CWE/CWE-190/AllocMultiplicationOverflow/test.cpp

@@ -16,7 +16,7 @@ void test()
 
 	if ((x <= 1000) && (y <= 1000))
 	{
-		char *buffer5 = (char *)malloc(x * y); // $ Alert // GOOD [FALSE POSITIVE]
+		char *buffer5 = (char *)malloc(x * y); // $ SPURIOUS: Alert // GOOD [FALSE POSITIVE]
 	}
 
 	size_t size1 = x * y; // $ Source

cpp/ql/test/experimental/query-tests/Security/CWE/CWE-193/constant-size/test.cpp

@@ -135,7 +135,7 @@ char testStrncmp2(char *arr) {
     if(strncmp(arr, "<test>", 6) == 0) {
         arr += 6; // $ Alert
     }
-    return *arr; // $ Sink // GOOD [FALSE POSITIVE]
+    return *arr; // $ SPURIOUS: Sink // GOOD [FALSE POSITIVE]
 }
 
 void testStrncmp1() {
@@ -144,7 +144,7 @@ void testStrncmp1() {
 }
 
 void countdownBuf1(int **p) {
-  *--(*p) = 1; // $ Sink // GOOD [FALSE POSITIVE]
+  *--(*p) = 1; // $ SPURIOUS: Sink // GOOD [FALSE POSITIVE]
   *--(*p) = 2; // GOOD
   *--(*p) = 3; // GOOD
   *--(*p) = 4; // GOOD
@@ -258,7 +258,7 @@ void call_use(unsigned char* p, int n) {
     if(n == 3) {
         unsigned char x = p[0];
         unsigned char y = p[1];
-        unsigned char z = p[2]; // $ Alert // GOOD [FALSE POSITIVE]: `call_use(buffer2, 2)` won't reach this point.
+        unsigned char z = p[2]; // $ SPURIOUS: Alert // GOOD [FALSE POSITIVE]: `call_use(buffer2, 2)` won't reach this point.
         use(x, y, z);
     }
 }
@@ -296,7 +296,7 @@ int guardingCallee(int *arr, int size) {
 
     int sum;
     for (int i = 0; i < size; i++) {
-        sum += arr[i]; // $ Alert // GOOD [FALSE POSITIVE] - guarded by size
+        sum += arr[i]; // $ SPURIOUS: Alert // GOOD [FALSE POSITIVE] - guarded by size
     }
     return sum;
 }
@@ -319,7 +319,7 @@ void correlatedCondition(int num) {
             end = temp + 56;
         }
         else if (num < 64) {
-            end = temp + 64; // $ Alert // GOOD [FALSE POSITVE]
+            end = temp + 64; // $ SPURIOUS: Alert // GOOD [FALSE POSITVE]
         }
         char *temp2 = temp + num;
         while(temp2 != end) { // $ Sink

cpp/ql/test/query-tests/Best Practices/Likely Errors/CommaBeforeMisleadingIndentation/test.cpp

@@ -163,7 +163,7 @@ int Foo::test(int (*baz)(int))
 
 	if (1) foo(
 		i++
-	), j++; // $ Alert // GOOD? [FALSE POSITIVE]
+	), j++; // $ SPURIOUS: Alert // GOOD? [FALSE POSITIVE]
 
 	if (1) baz(
 		i++

cpp/ql/test/query-tests/Best Practices/Likely Errors/OffsetUseBeforeRangeCheck/test.cpp

@@ -36,7 +36,7 @@ void test(char *buffer, int bufferSize)
 
 	// look for 'ab'
 	for (i = 0; i < bufferSize; i++) {
-		if ((buffer[i] == 'a') && (i < bufferSize - 1) && (buffer[i + 1] == 'b')) // $ Alert // GOOD [FALSE POSITIVE]
+		if ((buffer[i] == 'a') && (i < bufferSize - 1) && (buffer[i + 1] == 'b')) // $ SPURIOUS: Alert // GOOD [FALSE POSITIVE]
 			break;
 	}
 

cpp/ql/test/query-tests/Best Practices/Unused Entities/UnusedStaticVariables/test.cpp

@@ -9,7 +9,7 @@ static int staticVar6 = 6; // $ Alert // BAD (unused)
 static __attribute__((__unused__)) int staticVar7; // GOOD (unused but this is expected)
 const int constVar8 = 8; // $ Alert // BAD (const defaults to static)
 extern const int constVar9 = 9; // GOOD
-static int staticVar10 = 10; // $ Alert // GOOD [FALSE POSITIVE] (referenced in a never instantiated template)
+static int staticVar10 = 10; // $ SPURIOUS: Alert // GOOD [FALSE POSITIVE] (referenced in a never instantiated template)
 
 void f()
 {

cpp/ql/test/query-tests/Critical/MemoryFreed/my_auto_ptr.cpp

@@ -52,9 +52,9 @@ template<class T>
 class AutoContainer2
 {
 public:
-	AutoContainer2() : v(new T) // $ Alert[cpp/memory-never-freed] // GOOD [FALSE POSITIVE]
+	AutoContainer2() : v(new T) // $ SPURIOUS: Alert[cpp/memory-never-freed] // GOOD [FALSE POSITIVE]
 	{
-		ns::my_auto_ptr<T> ap(new T); // $ Alert[cpp/memory-never-freed] // GOOD [FALSE POSITIVE]
+		ns::my_auto_ptr<T> ap(new T); // $ SPURIOUS: Alert[cpp/memory-never-freed] // GOOD [FALSE POSITIVE]
 	}
 
 	ns::my_auto_ptr<T> v;
@@ -68,7 +68,7 @@ class AutoCloner
 	AutoCloner(AutoCloner &from) : val(from.val) {};
 
 	ns::my_auto_ptr<AutoCloner> clone() {
-		return ns::my_auto_ptr<AutoCloner>(new AutoCloner(*this)); // $ Alert[cpp/memory-never-freed] // GOOD [FALSE POSITIVE]
+		return ns::my_auto_ptr<AutoCloner>(new AutoCloner(*this)); // $ SPURIOUS: Alert[cpp/memory-never-freed] // GOOD [FALSE POSITIVE]
 	}
 
 private:

cpp/ql/test/query-tests/Critical/MemoryFreed/test_free.cpp

@@ -233,17 +233,17 @@ void test_loop3(char ** a, char ** b) {
         free(*a); // $ Source[cpp/use-after-free]
         a++;
     }
-    use(*a); // $ Alert[cpp/use-after-free] // GOOD [FALSE POSITIVE]
+    use(*a); // $ SPURIOUS: Alert[cpp/use-after-free] // GOOD [FALSE POSITIVE]
 
     for (;*b; b++) {
         free(*b); // $ Source[cpp/use-after-free]
     }
-    use(*b); // $ Alert[cpp/use-after-free] // GOOD [FALSE POSITIVE]
+    use(*b); // $ SPURIOUS: Alert[cpp/use-after-free] // GOOD [FALSE POSITIVE]
 }
 
 void test_deref(char **a) {
     free(*a); // $ Source[cpp/use-after-free]
-    use(*a); // $ Alert[cpp/use-after-free] // GOOD [FALSE POSITIVE]
+    use(*a); // $ SPURIOUS: Alert[cpp/use-after-free] // GOOD [FALSE POSITIVE]
 }
 
 // Refs

cpp/ql/test/query-tests/Critical/MissingCheckScanf/test.cpp

@@ -269,15 +269,15 @@ int main()
 
 		set_by_ref(i);
 		scanf("%d", &i); // $ Source[cpp/missing-check-scanf]
-		use(i); // $ Alert[cpp/missing-check-scanf] // GOOD [FALSE POSITIVE]
+		use(i); // $ SPURIOUS: Alert[cpp/missing-check-scanf] // GOOD [FALSE POSITIVE]
 	}
 
 	{
 		int i;
 
 		set_by_ptr(&i);
 		scanf("%d", &i); // $ Source[cpp/missing-check-scanf]
-		use(i); // $ Alert[cpp/missing-check-scanf] // GOOD [FALSE POSITIVE]
+		use(i); // $ SPURIOUS: Alert[cpp/missing-check-scanf] // GOOD [FALSE POSITIVE]
 	}
 
 	{
@@ -401,7 +401,7 @@ char *my_string_copy() {
     for (int i = 0; i < len; i += 2) {
 		unsigned int u;
 	    sscanf(src + i, "%2x", &u); // $ Source[cpp/missing-check-scanf]
-        *ptr++ = (char) u; // $ Alert[cpp/missing-check-scanf] // GOOD [FALSE POSITIVE]? src+i+{0,1} are always valid %x digits, so this should be OK.
+        *ptr++ = (char) u; // $ SPURIOUS: Alert[cpp/missing-check-scanf] // GOOD [FALSE POSITIVE]? src+i+{0,1} are always valid %x digits, so this should be OK.
     }
 	*ptr++ = 0;
 	return DST_STRING;
@@ -413,14 +413,14 @@ void scan_and_write() {
 		if (scanf("%d", &i) < 1) { // $ Source[cpp/missing-check-scanf]
 			i = 0;
 		}
-		use(i);  // $ Alert[cpp/missing-check-scanf] // GOOD [FALSE POSITIVE]: variable is overwritten with a default value when scanf fails
+		use(i);  // $ SPURIOUS: Alert[cpp/missing-check-scanf] // GOOD [FALSE POSITIVE]: variable is overwritten with a default value when scanf fails
 	}
 	{
 		int i;
 		if (scanf("%d", &i) != 1) { // $ Source[cpp/missing-check-scanf]
 			i = 0;
 		}
-		use(i);  // $ Alert[cpp/missing-check-scanf] // GOOD [FALSE POSITIVE]: variable is overwritten with a default value when scanf fails
+		use(i);  // $ SPURIOUS: Alert[cpp/missing-check-scanf] // GOOD [FALSE POSITIVE]: variable is overwritten with a default value when scanf fails
 	}
 }
 
@@ -481,7 +481,7 @@ void multiple_checks() {
 
 		if (res >= 0) {
 			if (res != 0) {
-				use(i); // $ Alert[cpp/missing-check-scanf] // GOOD: checks return value [FALSE POSITIVE]
+				use(i); // $ SPURIOUS: Alert[cpp/missing-check-scanf] // GOOD: checks return value [FALSE POSITIVE]
 			}
 		}
 	}
@@ -492,7 +492,7 @@ void multiple_checks() {
 
 		if (res < 0) return;
 		if (res != 0) {
-			use(i); // $ Alert[cpp/missing-check-scanf] // GOOD: checks return value [FALSE POSITIVE]
+			use(i); // $ SPURIOUS: Alert[cpp/missing-check-scanf] // GOOD: checks return value [FALSE POSITIVE]
 		}
 	}
 

cpp/ql/test/query-tests/JPL_C/LOC-4/Rule 29/NonConstFunctionPointer/test.c

@@ -17,5 +17,5 @@ void test()
 
 	funPtr1(); // $ Alert // BAD
 	funPtr2(); // $ Alert // BAD
-	funPtr3(); // $ Alert // GOOD [FALSE POSITIVE]
+	funPtr3(); // $ SPURIOUS: Alert // GOOD [FALSE POSITIVE]
 }

cpp/ql/test/query-tests/Likely Bugs/Arithmetic/PointlessComparison/PointlessComparison.c

@@ -261,7 +261,7 @@ int overeager_wraparound(unsigned int u32bound, unsigned long long u64bound) {
 
 int negative_zero(double dbl) {
   if (dbl >= 0) {
-    return dbl >= -dbl; // $ Alert[cpp/constant-comparison] // GOOD [FALSE POSITIVE]
+    return dbl >= -dbl; // $ SPURIOUS: Alert[cpp/constant-comparison] // GOOD [FALSE POSITIVE]
   }
   return 0;
 }