Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes a first step at converting a script from Python to TypeScript. Concretely, it replaces the
sync.pyscript that turns our PR check specifications into GitHub Actions workflows with a roughly equivalent TypeScript replacement.Initially, I aimed for exact textual equivalence in the output between the two scripts, but then I ultimately allowed a few minor changes:
stepsfrom the specification is now preserved more accurately.stepsare converted to single quoted strings.yamlpackage allows for unlimited line length, whichruamel.yamldidn't quite handle correctly before, so some lines are no longer wrapped as intended.I have left the
sync.pyscript around for the minute, and I have not yet tackled any other scripts.I initially started by using
js-yaml, since we already use this elsewhere in the repo, but then switched toyamlsince it gave me more control over the formatting.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Environments:
How did/will you validate this change?
pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist