Fix conditions in code scanning config checks for merge queue#3517
Merged
mbg merged 1 commit intombg/ci/merge-queue-codeqlfrom Feb 26, 2026
Merged
Conversation
DIff-informed analysis isn't enabled in the merge queue.
mbg
approved these changes
Feb 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect conditions in the code scanning config CLI test workflow that were treating merge_group events as if they were pull request events. Since merge_group events don't have pull request context, they cannot trigger diff-informed or overlay analysis features that add query filters like exclude-from-incremental.
Changes:
- Removed
|| github.event_name == 'merge_group'from two test step conditions, correctly classifying merge_group events as non-PR events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DIff-informed analysis isn't enabled in the merge queue.