Skip to content

[GHSA-3ppc-4f35-3m26] minimatch has a ReDoS via repeated wildcards with non-matching literal in pattern #7007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daniel-mudigital wants to merge 1 commit into from
+134 −1
Closed

[GHSA-3ppc-4f35-3m26] minimatch has a ReDoS via repeated wildcards with non-matching literal in pattern #7007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 134 additions & 1 deletion advisories/github-reviewed/2026/02/GHSA-3ppc-4f35-3m26/GHSA-3ppc-4f35-3m26.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"schema_version": "1.4.0",
"id": "GHSA-3ppc-4f35-3m26",
"modified": "2026-02-20T16:52:14Z",
"modified": "2026-02-20T16:52:16Z",
"published": "2026-02-18T22:38:11Z",
"aliases": [
"CVE-2026-26996"
Expand Down Expand Up @@ -33,6 +33,139 @@
]
}
]
},
{
"package": {
"ecosystem": "npm",
"name": "minimatch"
},
Comment on lines +37 to +41
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The affected array repeats identical package objects for minimatch many times, which is error-prone and hard to audit (and contributed to the overlapping-range issue above). If the schema allows, prefer a single affected entry for the package with multiple ranges (or multiple events sequences) to capture each fixed line, so the version logic is centralized and easier to review.

Copilot uses AI. Check for mistakes.
"ranges": [
{
"type": "ECOSYSTEM",
"events": [
{
"introduced": "0"
Copy link

@isaacs isaacs Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"introduced": "0"
"introduced": "0.0.0"

},
{
"fixed": "3.1.3"
}
]
Comment on lines +46 to +52
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These affected entries all start with introduced: \"0\" while only changing the fixed version. In OSV semantics, multiple affected records for the same package are effectively unioned; this makes the overall affected range extend up to the largest fixed version (e.g., 4.2.4, 5.1.7, etc.), which overstates impact if the vulnerability is already fixed in 3.1.3 for that line. Consider representing separate release lines with non-overlapping ranges (e.g., introduced: \"4.0.0\" -> fixed: \"4.2.4\", introduced: \"5.0.0\" -> fixed: \"5.1.7\", etc.) or combining into a single affected entry with multiple ranges/events that accurately reflect when each line became affected.

Copilot uses AI. Check for mistakes.
Copy link

@isaacs isaacs Feb 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I gotta agree with the bot on this one. They should be "introduced": "4.0.0", "fixed": "4.2.4" etc.

}
]
},
{
"package": {
"ecosystem": "npm",
"name": "minimatch"
},
Comment on lines +56 to +60
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The affected array repeats identical package objects for minimatch many times, which is error-prone and hard to audit (and contributed to the overlapping-range issue above). If the schema allows, prefer a single affected entry for the package with multiple ranges (or multiple events sequences) to capture each fixed line, so the version logic is centralized and easier to review.

Copilot uses AI. Check for mistakes.
"ranges": [
{
"type": "ECOSYSTEM",
"events": [
{
"introduced": "0"
Copy link

@isaacs isaacs Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"introduced": "0"
"introduced": "4.0.0"

},
{
"fixed": "4.2.4"
}
]
Comment on lines +64 to +71
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These affected entries all start with introduced: \"0\" while only changing the fixed version. In OSV semantics, multiple affected records for the same package are effectively unioned; this makes the overall affected range extend up to the largest fixed version (e.g., 4.2.4, 5.1.7, etc.), which overstates impact if the vulnerability is already fixed in 3.1.3 for that line. Consider representing separate release lines with non-overlapping ranges (e.g., introduced: \"4.0.0\" -> fixed: \"4.2.4\", introduced: \"5.0.0\" -> fixed: \"5.1.7\", etc.) or combining into a single affected entry with multiple ranges/events that accurately reflect when each line became affected.

Copilot uses AI. Check for mistakes.
}
]
},
{
"package": {
"ecosystem": "npm",
"name": "minimatch"
},
Comment on lines +75 to +79
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The affected array repeats identical package objects for minimatch many times, which is error-prone and hard to audit (and contributed to the overlapping-range issue above). If the schema allows, prefer a single affected entry for the package with multiple ranges (or multiple events sequences) to capture each fixed line, so the version logic is centralized and easier to review.

Copilot uses AI. Check for mistakes.
"ranges": [
{
"type": "ECOSYSTEM",
"events": [
{
"introduced": "0"
Copy link

@isaacs isaacs Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"introduced": "0"
"introduced": "5.0.0"

},
{
"fixed": "5.1.7"
}
]
Comment on lines +83 to +90
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These affected entries all start with introduced: \"0\" while only changing the fixed version. In OSV semantics, multiple affected records for the same package are effectively unioned; this makes the overall affected range extend up to the largest fixed version (e.g., 4.2.4, 5.1.7, etc.), which overstates impact if the vulnerability is already fixed in 3.1.3 for that line. Consider representing separate release lines with non-overlapping ranges (e.g., introduced: \"4.0.0\" -> fixed: \"4.2.4\", introduced: \"5.0.0\" -> fixed: \"5.1.7\", etc.) or combining into a single affected entry with multiple ranges/events that accurately reflect when each line became affected.

Copilot uses AI. Check for mistakes.
}
]
},
{
"package": {
"ecosystem": "npm",
"name": "minimatch"
},
"ranges": [
{
"type": "ECOSYSTEM",
"events": [
{
"introduced": "0"
Copy link

@isaacs isaacs Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"introduced": "0"
"introduced": "6.0.0"

},
{
"fixed": "6.2.1"
}
]
}
]
},
{
"package": {
"ecosystem": "npm",
"name": "minimatch"
},
"ranges": [
{
"type": "ECOSYSTEM",
"events": [
{
"introduced": "0"
Copy link

@isaacs isaacs Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"introduced": "0"
"introduced": "7.0.0"

},
{
"fixed": "7.4.7"
}
]
}
]
},
{
"package": {
"ecosystem": "npm",
"name": "minimatch"
},
"ranges": [
{
"type": "ECOSYSTEM",
"events": [
{
"introduced": "0"
Copy link

@isaacs isaacs Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"introduced": "0"
"introduced": "8.0.0"

},
{
"fixed": "8.0.5"
}
]
}
]
},
{
"package": {
"ecosystem": "npm",
"name": "minimatch"
},
"ranges": [
{
"type": "ECOSYSTEM",
"events": [
{
"introduced": "0"
Copy link

@isaacs isaacs Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"introduced": "0"
"introduced": "9.0.0"

},
{
"fixed": "9.0.6"
}
]
}
]
}
],
"references": [
Expand Down
Loading