Skip to content

docs: fix variable name in dynamic query error guide example #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itojum wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

docs: fix variable name in dynamic query error guide example #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion guides/dynamic-query-error.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ hero_query = SWAPI::Client.parse <<-'GRAPHQL'
}
}
GRAPHQL
result = SWAPI::Client.query(HeroNameQuery, variables: { id: params[:id] })
result = SWAPI::Client.query(hero_query, variables: { id: params[:id] })
```

Parsing a query and validating a query on every request adds performance overhead. It also prevents validation errors from being discovered until request time, rather than when the query is parsed at startup.
Expand Down