feat: support dynamic EC2 placement and block device overrides#5178
Open
edersonbrilhante wants to merge 2 commits into
Open
feat: support dynamic EC2 placement and block device overrides#5178edersonbrilhante wants to merge 2 commits into
edersonbrilhante wants to merge 2 commits into
Conversation
Add missing dynamic labels for EC2 placement and block device mappings, and align parseEc2OverrideConfig conditional order with the AWS SDK request property order.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
When dynamic EBS or block-device labels create an override without an explicit DeviceName, load the default launch template version by name and use its block device name for the CreateFleet override.
edersonbrilhante
force-pushed
the
fix-missing-ec2-labels
branch
from
75e774f to
ef6ce1a
Compare
edersonbrilhante
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add missing dynamic EC2 override labels for placement and block device mappings, and align
parseEc2OverrideConfigconditional ordering with the AWS SDK request property order.This adds parser support for:
ghr-ec2-placement-group-nameghr-ec2-placement-group-idghr-ec2-placement-availability-zone-idghr-ec2-block-device-nameWhen dynamic EBS or block device labels create an override without an explicit device name, scale-up now loads the default launch template version and uses its block device name for the CreateFleet override. The scale-up Lambda policy now includes
ec2:DescribeLaunchTemplateVersionsfor that lookup.Test Plan
Related Issues
#5173