refactor(control-plane): replace moment with the Temporal API#5177
Open
slavab89 wants to merge 2 commits into
Open
refactor(control-plane): replace moment with the Temporal API#5177slavab89 wants to merge 2 commits into
slavab89 wants to merge 2 commits into
Conversation
Drops the maintenance-mode moment / moment-timezone packages and adds temporal-polyfill ^0.3.2 (TC39 Stage 4; native in Node 26, polyfill until the Lambda runtime upgrades). Refs: github-aws-runners#3435 Co-authored-by: GitHub Copilot <copilot@github.com>
Rewrites bootTimeExceeded, runnerMinimumTimeExceeded, and inPeriod to use Temporal.Instant. Test fixtures adopt a minutesAgo() helper. Temporal.Instant.compare() replaces all relational comparisons on moment objects; Number.isFinite() guard preserves false-on-unset-env-var behavior. Refs: github-aws-runners#3435 Co-authored-by: GitHub Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the maintenance-mode
moment/moment-timezonepackages withtemporal-polyfill- a TC39 Stage 4 implementation that ships natively in Node 26.Dropping the polyfill later will be a one-line change.
Key changes:
Temporal.Instant.compare()replaces relational comparisons on moment objectsinPeriod—now.until(next).total('seconds')+Math.truncreplacesmoment.diff()Test Plan
temporal-polyfillfixtures.Related Issues
Closes #3435