fix: harden CLI network error handling#224
Merged
Merged
Conversation
Sanitize transport and OAuth failures, enforce secure service URLs, and route all startup errors through one CLI boundary. Add strict response validation, local-only recovery behavior, and regression coverage for the reviewed P0/P1 findings.
jlitola
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review findings
Implements quality-review items P0.1, P0.3, P1.1, and P1.3. This changes behavior exported through
@githits/mcp/clientand should receive the appropriate MCP patch bump during release preparation.Verification
bun test(2407 tests)bun run typecheckbun run lint(one pre-existing warning)bun run format:checkbun run smoke:clibun run smoke:mcpbun run smoke:proxy-nodebun run validate:packages:mcp-publish