Lite: misc#14008
Merged
Merged
Conversation
It was flickering e.g. when moving up/down the files list, in which case the contents of `headerWrap` never change.
It's unclear how stacks should appear in the details panel, and it would likely require API work which I raised previously. Let's leave it out for now.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38d8e4a90a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Lite workspace details UI by removing the commit Diff/Details toggle, always showing commit metadata above diffs, and cleaning up related components.
Changes:
- Updates commit details rendering and removes the
DiffStatcomponent/stories/styles. - Adds a shared
commitBody()helper for extracting commit message bodies. - Adjusts workspace outline/details panel layout and button trigger behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
apps/lite/ui/src/routes/project/$id/workspace/OutlinePanel.tsx |
Forwards combobox disabled state to the underlying button. |
apps/lite/ui/src/routes/project/$id/workspace/OutlinePanel.module.css |
Adjusts commit dropdown button layout. |
apps/lite/ui/src/routes/project/$id/workspace/DetailsPanel.tsx |
Simplifies commit detail/diff rendering and removes toggle state. |
apps/lite/ui/src/routes/project/$id/workspace/DetailsPanel.module.css |
Updates header and commit detail layout styles. |
apps/lite/ui/src/components/DiffStat.tsx |
Removes unused diff stat component. |
apps/lite/ui/src/components/DiffStat.stories.tsx |
Removes obsolete stories. |
apps/lite/ui/src/components/DiffStat.module.css |
Removes obsolete styles. |
apps/lite/ui/src/commit.ts |
Adds commitBody() helper. |
OliverJAsh
force-pushed
the
push-kvprpmsvspkk
branch
from
560c3bc to
7030931
Compare
The `includes` condition had false positives e.g. for commits created with `git commit -m "foo"`, which appear to have a trailing newline character.
Like we do for the files list. Fixes an issue where parts of the header would disappear when selecting commit files.
*Pointer* transfer tooltips are special because they may be anchored to the insertion target rather than main target. I wanted to decouple the tooltip for other outline modes from the `OperationTarget` component because these tooltips are used outside of operation targets, e.g. when absorbing a file, the changes section will become a selected and show a tooltip, in which case it is neither an operation source nor target.
OliverJAsh
force-pushed
the
push-kvprpmsvspkk
branch
from
7030931 to
d2f905b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.