fix(but): print normalized name after creating branch#13159
Closed
slarse wants to merge 2 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
rust
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes but branch new output so users see the normalized branch name that was actually created (instead of the original, non-normalized input).
Changes:
- Capture the normalized refname returned from
create_reference_with_perm()and print the normalized short name in human/JSON output. - Add e2e coverage for normalization behavior (human output + JSON output).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
crates/but/src/command/legacy/branch/mod.rs |
Uses the normalized refname for human output and JSON output after branch creation. |
crates/but/tests/but/command/branch/new.rs |
Adds tests asserting normalized-name behavior for human output and JSON output. |
slarse
force-pushed
the
GB-1247/branch-new-print-normalized-name
branch
from
5bdf2cc to
21dde80
Compare
`but branch new` always created the new branch with a normalized name, but name reported to users was the original non-normalized input, making it a li'l bit confusing.
slarse
force-pushed
the
GB-1247/branch-new-print-normalized-name
branch
from
21dde80 to
2b7c3f5
Compare
Contributor
Author
|
Has been effectively replaced by #13929 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
but branch newalways created the new branch with a normalized name, but the name reported to users was the original non-normalized input, making it a li'l bit confusing.Also took the opportunity to notify the user that the branch name was normalized.
Before:
After:
TODO
Tests probably need revising as I realized that trailing dashes are actually fine by Git, it's just GitButler that strips them away for some reason. I think this is wrong.