feat(but): make ids bold instead of underlined#12397
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
bot
added
rust
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves CLI readability by changing the styling of ID displays from underlined to bold. IDs include commit IDs, CLI IDs, stack IDs, and other identifier strings throughout the but CLI tool.
Changes:
- Replaced
.underline()with.bold()for all ID displays across the CLI codebase - Maintained existing method chaining patterns (
.blue().bold()or.bold().blue()as per existing code) - Correctly preserved underline styling for URLs and headers (which are not IDs)
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/but/src/command/legacy/status/mod.rs | Updated ID styling in status display, including stack IDs, CLI IDs, commit IDs, and change IDs |
| crates/but/src/command/legacy/rub/squash.rs | Updated ID styling in squash error messages |
| crates/but/src/command/legacy/rub/move.rs | Updated source and target ID styling in move operation error messages |
| crates/but/src/command/legacy/rub/mod.rs | Updated ID styling in various rub command error messages (uncommit, amend, stage, unstage) |
| crates/but/src/command/legacy/rub/amend.rs | Updated commit ID styling in amend success messages |
| crates/but/src/command/legacy/oplog.rs | Updated snapshot/commit ID styling in oplog display and restore operations |
| crates/but/src/command/legacy/diff/display.rs | Updated ID styling in diff display for hunk assignments |
PavelLaptev
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧢 Changes
Makes IDs in the CLI bold instead of underlined to increase readability. There are some before/after SVG comparisons in 82c1fc3, but I don't really think they do the changes justice. Here are some samples from my terminal with before followed by after (
butis the before,but-debugis the after):Status
This is the one I had the most trouble reading, with e.g.
p,qandycutting through the underline. I was quite literally squinting at the text, and among other things mistook ayfor avat some point (see the branchyv-demoat the bottom,yandvlook very similar to my eyes when underlined).Oplog
Diff
URLs
And URL's are left unchanged, still underlined: