-
Notifications
You must be signed in to change notification settings - Fork 0
fix(bisect): harden CLI validation and remove dead code (B148) #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
afe9dc9
feat(api)!: normalize getNodeProps() to return Record (B100)
flyingrobots 243713a
refactor(types): unify CorePersistence/FullPersistence typedefs (B146)
flyingrobots 4e20ea3
feat(api): stabilize Observer API — subscribe() and watch() (B3)
flyingrobots 42e5377
feat(api): add graph.patchMany() batch patch API (B11)
flyingrobots a8c241b
feat(bisect): add BisectService for binary search over WARP history
flyingrobots 138f03b
feat(bisect): implement causality bisect CLI and service (B2)
flyingrobots 774d697
test(subscribe): add unsubscribe-during-callback E2E tests (B44)
flyingrobots b07d64d
test(trust): add CLI vs service payload parity tests (B124)
flyingrobots 815e6e2
test(CachedValue): add null-payload semantic tests (B125)
flyingrobots 001d0c1
release: v13.0.0
flyingrobots 1ea6bc4
fix(release): resolve TypeScript and declaration surface errors for v…
flyingrobots b87b83b
fix(bisect): harden CLI validation and remove dead code (B148)
flyingrobots d7cf956
fix(docs): reconcile inventory counts and fix review nits (B148)
flyingrobots c1d73ad
docs(changelog): add B148 follow-up details
flyingrobots 367efdf
fix(docs,types): address code review round 2 findings (B148)
flyingrobots 1b3cfcc
fix(security,cli,docs): address CodeRabbit review feedback (B148)
flyingrobots 65f0f56
fix(docs,security): address CodeRabbit round 4 nits (B148)
flyingrobots File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| import { execSync } from 'node:child_process'; | ||
| import { EXIT_CODES, parseCommandArgs, usageError } from '../infrastructure.js'; | ||
| import { bisectSchema } from '../schemas.js'; | ||
| import { openGraph } from '../shared.js'; | ||
| import BisectService from '../../../src/domain/services/BisectService.js'; | ||
|
|
||
| /** @typedef {import('../types.js').CliOptions} CliOptions */ | ||
|
|
||
| const BISECT_OPTIONS = { | ||
| good: { type: 'string' }, | ||
| bad: { type: 'string' }, | ||
| test: { type: 'string' }, | ||
| }; | ||
|
|
||
| /** @param {string[]} args */ | ||
| function parseBisectArgs(args) { | ||
| const { values } = parseCommandArgs(args, BISECT_OPTIONS, bisectSchema); | ||
| return values; | ||
| } | ||
|
|
||
| /** | ||
| * Runs a shell command as the bisect test. | ||
| * | ||
| * @param {string} testCmd - Shell command to execute | ||
| * @param {string} sha - Candidate patch SHA (passed as env var) | ||
| * @param {string} graphName - Graph name (passed as env var) | ||
| * @returns {boolean} true if the command exits 0 (good), false otherwise (bad) | ||
| */ | ||
| function runTestCommand(testCmd, sha, graphName) { | ||
| try { | ||
| execSync(testCmd, { | ||
| stdio: 'pipe', | ||
| env: { | ||
| ...process.env, | ||
| WARP_BISECT_SHA: sha, | ||
| WARP_BISECT_GRAPH: graphName, | ||
| }, | ||
| }); | ||
| return true; | ||
| } catch { | ||
| return false; | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| } | ||
|
|
||
| /** | ||
| * Handles the `bisect` command: binary search over patch history. | ||
| * @param {{options: CliOptions, args: string[]}} params | ||
| * @returns {Promise<{payload: unknown, exitCode: number}>} | ||
| */ | ||
| export default async function handleBisect({ options, args }) { | ||
| if (options.writer === 'cli') { | ||
| throw usageError('bisect requires --writer <id>'); | ||
| } | ||
|
|
||
| const { good, bad, test: testCmd } = parseBisectArgs(args); | ||
| const { graph, graphName } = await openGraph(options); | ||
| const writerId = options.writer; | ||
|
|
||
| const bisect = new BisectService({ graph }); | ||
|
|
||
| const result = await bisect.run({ | ||
| good, | ||
| bad, | ||
| writerId, | ||
| testFn: (_state, sha) => Promise.resolve(runTestCommand(testCmd, sha, graphName)), | ||
| }); | ||
|
|
||
| if (result.result === 'range-error') { | ||
| return { | ||
| payload: { error: { code: 'E_BISECT_RANGE', message: result.message } }, | ||
| exitCode: EXIT_CODES.NOT_FOUND, | ||
| }; | ||
| } | ||
|
|
||
| const payload = { | ||
| result: 'found', | ||
| firstBadPatch: result.firstBadPatch, | ||
| writerId: result.writerId, | ||
| lamport: result.lamport, | ||
| steps: result.steps, | ||
| totalCandidates: result.totalCandidates, | ||
| }; | ||
|
|
||
| return { payload, exitCode: EXIT_CODES.OK }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.