Fix refetch behaviour of react query hooks #19
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR optimizes React Query caching behavior to reduce unnecessary API calls by setting a 5-minute stale time and disabling automatic refetches on mount and window focus. The UI messaging has been updated to inform users about the potential 5-minute data delay.
Changes:
- Configure React Query hooks with 5-minute staleTime and disabled auto-refetch behavior
- Update dashboard note to clearly communicate the 5-minute cache window
- Improve HTML structure by using semantic
<div>and<p>tags
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/api/queries/get_user_progress.ts | Added staleTime (5 minutes) and disabled refetchOnMount and refetchOnWindowFocus |
| src/api/queries/get_user.ts | Added staleTime (5 minutes) and disabled refetchOnMount and refetchOnWindowFocus |
| src/api/queries/get_exercises.ts | Added staleTime (5 minutes) and disabled refetchOnMount and refetchOnWindowFocus |
| src/components/dashboard/DashboardHeader.tsx | Updated note text to mention 5-minute delay and restructured HTML with proper semantic tags |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
Fix refetch behaviour of useQuery hooks to stop refetching on mount and focus unnecessarily, and set stale time as 5 minutes.
@damithc In this PR, I also updated the note as shown below to indicate that changes might not be include updates in the last 5 minutes.