chore: use tailwindcss for styling#6
Open
jiaxinnns wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Migrates the app's styling from inline style objects and per-component CSS files to Tailwind CSS v4 utility classes, per issue #3. Mantine components remain in place; layout primitives like Flex/Stack/Group/Box are largely replaced with <div> + Tailwind utilities, and a small @theme block preserves the custom gm-green/gm-bone/gm-dark-green colors.
Changes:
- Add
@tailwindcss/vite+tailwindcssv4, register the Vite plugin, and introducesrc/ui/tailwind.csswith theme tokens. - Delete
App.css,index.css, andTourList.module.css; replace inlinestyle={}and many Mantine layout components with TailwindclassNameutilities across pages and components. - Refactor
ExerciseListstatus indicators into a singleStatusDotcomponent driven by aRecord<ProgressState, ...>map.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Registers the Tailwind Vite plugin. |
| src/ui/tailwind.css | New Tailwind entrypoint with custom color theme tokens. |
| src/ui/main.tsx | Imports the new tailwind.css. |
| src/ui/index.css | Removed; typography defaults are no longer applied. |
| src/ui/App.css | Removed legacy starter styles. |
| src/ui/App.tsx | Switches AppShell.Main style to Tailwind classes. |
| src/ui/pages/Onboarding.tsx | Rewrites step layouts using Tailwind utilities and trims unused imports. |
| src/ui/components/Header/Header.tsx | Replaces inline styles with utility classes. |
| src/ui/components/Website/WebsiteWrapper.tsx | Converts layout to flex utilities. |
| src/ui/components/Terminal/Terminal.tsx | Uses Tailwind classes for terminal container. |
| src/ui/components/Navigation/LeftBarWrapper.tsx | Rewrites sidebar layout; changes scroll behavior (see comment). |
| src/ui/components/Navigation/TourList.tsx | Replaces module CSS + inline styles with Tailwind classes. |
| src/ui/components/Navigation/TourList.module.css | Removed in favor of Tailwind transition utilities. |
| src/ui/components/Navigation/ExerciseList.tsx | Consolidates status dot components and converts layout to utilities. |
| package.json / package-lock.json | Adds tailwindcss and @tailwindcss/vite dev dependencies. |
Comments suppressed due to low confidence (1)
src/ui/index.css:1
- Removing
index.cssdrops the typography defaults that setfont-family: 'Inter'on the body and'Noto Serif'/Georgia onh1–h6. There is no equivalent replacement intailwind.css(no--font-*theme tokens or base styles), so all text in the app now falls back to the browser/Mantine default fonts. If the intent is to keep the previous look, please re-establish these font families either via@themetokens intailwind.cssand a@layer baserule, or in the Mantine theme configuration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+14
to
+22
| return <div className="flex flex-col justify-between h-full"> | ||
| {/* Tours */} | ||
| <Stack style={{ | ||
| overflowY: "scroll", | ||
|
|
||
| }}> | ||
|
|
||
| <div className="flex flex-col overflow-y-scroll"> | ||
| <TourList /> | ||
|
|
||
| {/* Lessons (scrollable) */} | ||
| <Flex flex={1}> | ||
| <div className="flex flex-1"> | ||
| <ExerciseList /> | ||
|
|
||
| </Flex> | ||
|
|
||
| </Stack> | ||
| <Flex style={{ flexGrow: 1 }}> | ||
|
|
||
| </Flex> | ||
| </div> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3