Add ucrt64 support for minimal, makepkg-git, and build-installers flavors#1362
Merged
Conversation
When the `ucrt64` axis first landed, only `flavor: full` worked: the subset flavors call out to `please.sh create-sdk-artifact` in `build-extra`, and that script did not understand `--architecture=ucrt64` at the time. That has since been fixed, so all four flavors work for `ucrt64`. Drop the now-stale "only the `full` flavor is supported" sentence from the action description. Assisted-by: Opus 4.7 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Match the action.yml change of the previous commit: with `please.sh create-sdk-artifact --architecture=ucrt64` now a working invocation, all four flavors are viable on the `ucrt64` axis. Assisted-by: Opus 4.7 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Match the preceding action.yml and README updates. With `please.sh create-sdk-artifact --architecture=ucrt64` now a working invocation, all four flavors take the `getViaGit` path successfully on the `ucrt64` axis, so the table cell and the explanatory paragraph no longer need to single `full` out. The ci-artifacts fast path remains suppressed for `ucrt64` because the `ci-artifacts` release of `git-sdk-64` still carries no UCRT64 asset; reword the paragraph to spell out what that means in practice (every flavor goes through `please.sh`). The table-column realignment is a no-op produced by `npm run format` since the longest cell in the notes column shrank. Assisted-by: Opus 4.7 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The per-PR `test` matrix already covered `ucrt64` + `full` end-to-end. Now that `please.sh create-sdk-artifact --architecture=ucrt64` works, extend the matrix with the three subset flavors so a regression on the `getViaGit` -> `please.sh` path for `ucrt64` is caught on every PR rather than first surfacing in a consumer repository. `mingw_prefix` stays at `/ucrt64` for all three new rows; the verification step's `$MINGW_PREFIX/bin/gcc` assertion checks the same path on every flavor, since `gcc` is present in `minimal`, `makepkg-git`, `build-installers`, and `full` alike. Also drop the now-stale comment explaining why `ucrt64` only had a `full` row. Assisted-by: Opus 4.7 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
ucrt64-subset-flavors
branch
from
0af9fda to
ba0ca61
Compare
The manually-triggered `test all artifact flavors` matrix already covers every flavor on `i686` and `x86_64`. Add `ucrt64` as a third value in the `architecture` array so the same four flavors get spawned against it too, replacing the previous one-row `include` block (which was added when only `flavor: full` worked for `ucrt64`) and dropping the now-stale comment that justified that asymmetry. Assisted-by: Opus 4.7 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
ucrt64-subset-flavors
branch
from
ba0ca61 to
55a803a
Compare
Member
Author
|
Closing and reopening to make up for GitHub missing that part of this branch has already been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1361, which added the
ucrt64axis but only forflavor: full. This PR extends that to theminimal,makepkg-git, andbuild-installersflavors so theucrt64axis is on equal footing with the others.The Action itself doesn't need new source code for this; it just needed
please.sh create-sdk-artifact --architecture=ucrt64to be a working invocation, which is what git-for-windows/build-extra#710 adds. So the diff here is documentation hygiene (removing the "onlyfullfor now" caveats) and matrix extensions (so the new combinations are exercised both on every PR and in the manual all-flavors run). The CI-artifacts fast path stays suppressed forucrt64until upstream grows a UCRT64 asset; that is a separate concern.