Harden internal git profiles against non-standard diff configs#593
Merged
Harden internal git profiles against non-standard diff configs#593
Conversation
Member
Author
|
Addressed Devin review in
Re-running CI on latest head now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
General,PatchParse,NumstatParse,RawDiffParse) and route parse-sensitive callsites through them+++headers to handle no-prefix/custom-prefix/mnemonic-style pathsdiff.*config integration coverage for simple additions, diff, stats, and statusHardening fixes added after review
--, so pathspec tokens are never droppedNumstatParsenow strips short rename/copy variants (-M*,-C*) so--no-renamescannot be overridden later in argvcontinue_sessionpatch-producinggit shownow usesPatchParseprofile for stable output under hostilediff.*configValidation
cargo test --lib numstat_profile_strips_short_rename_and_copy_flagscargo test --lib profile_rewrite_does_not_strip_pathspec_tokens_after_double_dashcargo test --tests --no-runcargo test --test simple_additions test_simple_additions_with_base_commit_and_custom_diff_config -- --nocapturecargo test --test diff test_diff_parsing_is_stable_under_hostile_diff_config -- --nocapturecargo test --test stats test_stats_cli_range_with_hostile_diff_config -- --nocapturecargo test --test status_ignore test_status_numstat_is_stable_under_hostile_diff_config -- --nocapturecargo test --test internal_spawn_safety direct_git_command_spawns_are_centralized -- --nocapturecargo test --test continue_session -- --nocapturecargo fmt -- --check