fix: improve Windows compatibility for daemon telemetry and hook commands#1389
Open
tanbazhagan wants to merge 2 commits into
Open
fix: improve Windows compatibility for daemon telemetry and hook commands#1389tanbazhagan wants to merge 2 commits into
tanbazhagan wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR standardizes how agent hook commands are constructed—especially on Windows—by normalizing binary paths for shell execution, while also improving Windows cleanup behavior and adjusting a Windows-specific daemon telemetry connect timeout.
Changes:
- Added
to_agent_hook_command_path()and updated multiple agent installers to use it for hook command construction (Windows usesC:/...-style paths). - Improved Windows symlink/junction removal behavior in
ensure_git_symlinks()to surface failures instead of swallowing them. - Increased the telemetry connect timeout on Windows to better match daemon startup behavior.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mdm/utils.rs | Adds a shared path-normalization helper for hook command execution. |
| src/mdm/ensure_git_symlinks.rs | Adjusts Windows junction/symlink removal flow and error surfacing. |
| src/mdm/agents/windsurf.rs | Uses normalized command path when building Windsurf hook command. |
| src/mdm/agents/github_copilot.rs | Uses normalized command path and tolerates legacy MSYS-style commands on Windows. |
| src/mdm/agents/gemini.rs | Uses normalized command path when building Gemini hook commands. |
| src/mdm/agents/firebender.rs | Uses normalized command path when building Firebender hook commands. |
| src/mdm/agents/droid.rs | Uses normalized command path when building Droid hook commands. |
| src/mdm/agents/cursor.rs | Uses normalized command path and updates tests accordingly. |
| src/mdm/agents/codex.rs | Uses normalized command path; adds legacy MSYS compatibility in “up-to-date” detection. |
| src/daemon/telemetry_handle.rs | Sets a longer telemetry connect timeout on Windows with rationale. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Author
|
@copilot apply changes based on the comments in this thread |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: improve Windows compatibility for daemon telemetry and hook commands