Make nix package derivations overridable#1371
Open
AZMCode wants to merge 12 commits into
Open
Conversation
- Make packages overridable - Make overlays use the previous pkgs version to build packages - Make home-manager and nixos modules use ambient nixpkgs for building - Add option gitBasePackage to nixos and home-manager modules to allow overriding base git package through configuration
Author
|
Wow, got scared by the CLA requirement. |
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…s always available when the package is called
Now override functions are exposed through the 'scope' attribute
- Fix `override` function being called from git-ai attrset instead of its enclosing scope - Fix `wrapped` package being no longer exposed under `packages` - Fix `callPackage` on default.nix shadowing `makeScope`s `override` function
Author
|
Welp. That took a lot of iterating. Apologies for doing this on the PR, I should've been more careful. |
Member
|
Thank you for the contribution! Adding @jwiegley for the Nix stuff (I'm not familiar with all the ins and outs of the Nix config!) |
Author
|
This is some of my first contributions to Nix in OSS, so pointers and feedback are definitely welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1346