Skip to content

Make nix package derivations overridable#1371

Open
AZMCode wants to merge 12 commits into
git-ai-project:mainfrom
AZMCode:main
Open

Make nix package derivations overridable#1371
AZMCode wants to merge 12 commits into
git-ai-project:mainfrom
AZMCode:main

Conversation

@AZMCode
Copy link
Copy Markdown

@AZMCode AZMCode commented May 13, 2026

  • Make packages overridable
  • Make overlays use the previous pkgs version to build packages
  • Make home-manager and nixos modules use ambient nixpkgs for building
  • Add option gitBasePackage to nixos and home-manager modules to allow overriding base git package through configuration

Fixes #1346


Open in Devin Review

- Make packages overridable
- Make overlays use the previous pkgs version to build packages
- Make home-manager and nixos modules use ambient nixpkgs for building
- Add option gitBasePackage to nixos and home-manager modules to
  allow overriding base git package through configuration
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 13, 2026

CLA assistant check
All committers have signed the CLA.

devin-ai-integration[bot]

This comment was marked as resolved.

@AZMCode
Copy link
Copy Markdown
Author

AZMCode commented May 13, 2026

Wow, got scared by the CLA requirement.
Turns out I just needed to consent to the Apache-2.0 license
Is a CLA signing necessary for Apache-2.0 to apply?
/Off Topic

AZMCode and others added 5 commits May 13, 2026 16:12
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration[bot]

This comment was marked as resolved.

AZMCode and others added 2 commits May 13, 2026 16:55
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

…s always available when the package is called
devin-ai-integration[bot]

This comment was marked as resolved.

Now override functions are exposed through the 'scope' attribute
devin-ai-integration[bot]

This comment was marked as resolved.

- Fix `override` function being called from git-ai attrset instead of its enclosing scope
- Fix `wrapped` package being no longer exposed under `packages`
- Fix `callPackage` on default.nix shadowing `makeScope`s `override`
  function
@AZMCode
Copy link
Copy Markdown
Author

AZMCode commented May 14, 2026

Welp. That took a lot of iterating. Apologies for doing this on the PR, I should've been more careful.
This should be ready for human review, I'm pretty sure.

@svarlamov
Copy link
Copy Markdown
Member

Thank you for the contribution! Adding @jwiegley for the Nix stuff (I'm not familiar with all the ins and outs of the Nix config!)

@AZMCode
Copy link
Copy Markdown
Author

AZMCode commented May 21, 2026

This is some of my first contributions to Nix in OSS, so pointers and feedback are definitely welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow fully overriding git package used in the nix flake.

4 participants