fix(render): improve JsonpJSON content type handling and simplify Context.JSONP#4427
Open
1911860538 wants to merge 2 commits intogin-gonic:masterfrom
Open
fix(render): improve JsonpJSON content type handling and simplify Context.JSONP#44271911860538 wants to merge 2 commits intogin-gonic:masterfrom
1911860538 wants to merge 2 commits intogin-gonic:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4427 +/- ##
==========================================
- Coverage 99.21% 98.96% -0.25%
==========================================
Files 42 44 +2
Lines 3182 2898 -284
==========================================
- Hits 3157 2868 -289
- Misses 17 19 +2
- Partials 8 11 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@appleboy CC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes several improvements to JSONP handling:
Content Type Correction for JsonpJSON
Context.JSONP Method Simplification
Test Updates
These changes improve code maintainability
while ensuring JSONP responses conform to proper standards.
According to JSONP (JSON with Padding) definition,
it is a technique for sending JSON data
without worrying about cross-domain issues
by wrapping the JSON response in a JavaScript function call.
Ref #1438