Complete S7CommPlus V1 session handshake#661
Merged
gijzelaerr merged 1 commit intomasterfrom Mar 27, 2026
Merged
Conversation
Instead of probing data operations and falling back on ERROR2, properly complete the V1 session setup by parsing ServerSessionVersion (attribute 306) from the CreateObject response and echoing it back via SetMultiVariables. This should fix the ERROR2 (0x05A9) rejections from real S7-1200/1500 PLCs with firmware v4.0+. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
gijzelaerr
added a commit
that referenced
this pull request
Mar 27, 2026
Resolve conflicts in s7/_s7commplus_client.py and s7/_s7commplus_async_client.py — keep our refactored versions which already include the session setup fix from #661 but without the fallback logic (now owned by s7.Client). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServerSessionVersion(attribute 306) from theCreateObjectresponse and echo it back to the PLC viaSetMultiVariables, completing the V1 session handshake_probe_s7commplus_data) — instead use the session setup result to decide whether to fall back to legacy S7Test plan
pytest tests/test_s7commplus_e2e.py --e2e --plc-ip=<IP> --plc-port=<PORT> -v🤖 Generated with Claude Code