feat(showcase): new page to display config#201
feat(showcase): new page to display config#201DeadEnglish wants to merge 19 commits intoghostty-org:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
See #203 for Tag component |
|
For posterity: shared on discord. The direction of this PR so far is good! |
|
@DeadEnglish I missed you flipped this to ready for review. I'll try to review this soon :) |
|
Cheers, also no rush on the review, I've been somewhat afk due to work 😅 |
|
Hey @BrandonRomano it's been a fair while and I've been busy at work 😅. Would appreciate a review of any kind when you get a chance 😄 |
|
Sorry @DeadEnglish it has been quite a while. I've also been busy with work, but I will pen you down to try to get a review here tonight! Edit: I will get to it this weekend! Hah sorry having a week. |
BrandonRomano
left a comment
There was a problem hiding this comment.
This is really good & clean work. Nice work @DeadEnglish. Sorry I literally took months to review it 😭.
I think the only thing I can think of is potentially wanting to think about how contributors can add in a new showcase item. (e.g. perhaps adding a small README into the showcase directory). I imagine this will get filled up quickly!
|
Also been super busy so no worries, thanks for the review! Will update with a readme at some point this week and hopefully we can start showcasing some configs! |
What does this do?
Starting the work on #125, getting the general layout correct.
classNameprop toCodeBlockto add custom stylingclassNameprop toTagListto add custom stylingTODO
Tag component (maybe a different PR)See feat(tag): new component #203Videos/Images
Showcase list
Screen.Recording.2024-12-28.at.13.10.32.mp4
Working example
Screen.Recording.2025-02-01.at.12.49.14.mp4