feat: add --threads-all option to llama-bench#25261
Open
xiaobai0529 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new command-line option
-ta/--threads-alltollama-benchthat uses all logical cores (including SMT/hyperthreading) instead of only physical cores.Problem
As discussed in issue #17611, llama-bench currently uses
cpu_get_num_math()which returns the number of physical cores. On systems with SMT/hyperthreading enabled (e.g., dual CPU with 36 cores / 72 threads), this results in only 50% CPU utilization being reported by default.While using physical cores is generally optimal for llama.cpp workloads, users who want to benchmark their system's full capabilities need to manually specify thread count with
-t 72.Solution
Add a convenient
-ta/--threads-allflag that automatically usesstd::thread::hardware_concurrency()to get all logical cores.Usage
# Use all logical cores (including SMT) ./llama-bench -ta ./llama-bench --threads-all