-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add fields to get_image_metadata result #3059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
Include the file extension we're using, and make it clear that we're reading metadata, not necessarily the image itself.
This way we won't have to parse multiple times when calling multiple helpers.
|
I made the type for LMK if you think there's a better approach here. |
Nope it's not possible, we would need to expose a specific type in the Value enum in Tera for datetimes, I considered it for tera2 but ended up not doing it because it adds lots of complexity to handle all the tz/various libraries. I will add some tests though, eg |
| }; | ||
|
|
||
| if bytes.len() == 0 { | ||
| eprintln!("String value for {:?} has empty Ascii vec.", tag); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we bubble those as errors so the user will know which image it's for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and is an empty value an error?
Add the
descriptionandcreatedfields toImageMetaResponseso that they will be accessible to callers ofget_image_metadata.Fixes #3053
Sanity check:
Code changes
nextbranch?