Sorted subsections#2372
Open
bemyak wants to merge 4 commits intogetzola:nextfrom
Open
Conversation
bemyak
force-pushed
the
sorted-subsections
branch
from
e66c2a5 to
344fbd7
Compare
As per Vincent's comment, the subsections should have the same lower/higher properties as pages.
bemyak
force-pushed
the
sorted-subsections
branch
from
344fbd7 to
a3fe5ef
Compare
Keats
force-pushed
the
next
branch
2 times, most recently
from
8b1a413 to
67c2fe0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds subsection sorting and introduces
lowerandhigherfields to make sections more consistent with pages. As pointed here, these fields are supposed to be there.An open question remains: how should we treat subsections of a transparent section? I raised this question here, but so far there is no definite conclusion, so I'm leaving it out of the scope of this PR.
Sanity check:
Code changes
nextbranch?