evanh/fix/default implementations #533
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
evanh
commented
Jan 15, 2026
evanh
commented
- attempt
- attempt to make default implementation
evanh
commented
Jan 15, 2026
| .acquire_read_pool("pending_activation_max_lag") | ||
| .await | ||
| .unwrap(); | ||
| let result = sqlx::query( |
Member
Author
There was a problem hiding this comment.
At this line I get this error:
the trait bound `&mut <... as Database>::Connection: Executor<'_>` is not satisfied
the full name for the type has been written to '/Users/evanhicks/code/getsentry/taskbroker/target/debug/deps/taskbroker-613d671e018d10ef.long-type-230211601191496010.txt'
consider using `--verbose` to print the full type name to the consolerustcClick for full compiler diagnostic
query.rs(188, 12): required by a bound in `sqlx::query::Query::<'q, DB, A>::execute`
inflight_activation.rs(274, 47): consider introducing a `where` clause, but there might be an alternative better way to express this requirement: ` where &mut <<Self as store::inflight_activation::InflightActivationStore>::Database as sqlx::Database>::Connection: sqlx::Executor<'_>`
I'm not sure how to fix this. Cursor was very unhelpful.
This reverts commit 5a1bf41.
evanh
commented
Jan 15, 2026
|
|
||
| /// Get the size of the database in bytes | ||
| async fn db_size(&self) -> Result<u64, Error>; | ||
| type Database: Database; |
Member
Author
There was a problem hiding this comment.
This was a core change, it's what allowed me to have the acquire_..._conn functions in the Trait, which I need to move any function that runs an actual query.
Member
There was a problem hiding this comment.
Nice, so postgres/sqlite have an associated type which gets around the trait object problem?
Member
Author
There was a problem hiding this comment.
In theory, yes, although see the error I posted about above that I can't get around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.