fix(auth): Exempt invited SSO signups from required email verification - #122812
Draft
nora-shap wants to merge 1 commit into
Draft
fix(auth): Exempt invited SSO signups from required email verification#122812nora-shap wants to merge 1 commit into
nora-shap wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dd12f5c. Configure here.
| is not None | ||
| ) | ||
| if already_a_member: | ||
| return False |
Contributor
There was a problem hiding this comment.
Membership probe skips fail-open handling
Low Severity
_email_verified_via_pending_invite() is documented to fail open on any error, but the authenticated check_membership_by_id probe sits outside the try/except. An RPC or lookup failure there raises out of the newuser path instead of falling back to the verification email, so signup can 500 rather than continue.
Reviewed by Cursor Bugbot for commit dd12f5c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Clicking an org invite link already proves the user owns that inbox, but the
auth:email-verification-at-sso-signupgate didn't know about invites: it ran before the invite was ever looked up, so an invited user got forced through a second, redundant verification email.AuthIdentityHandler._email_verified_via_pending_invite()now folds into the existingis_trustedcheck: exempt only if the session carries a valid, approved, unexpired invite token (not merely "an invite exists for this email") for a member whose email matches the SSO identity.Bails if
request.useris authenticated and already a member of this org, sinceApiInviteHelper's lookup checks membership before the invite cookie and could otherwise resolve the wrong row. An authenticated user who isn't yet a member (an existing Sentry user invited to a different org, declining to merge accounts) still gets the exemption. Fails open on any error, falling back to requiring verification rather than blocking signup.Note: this duplicates a read
_handle_membership()already does later to accept the invite. Left as is (cheap, read only) rather than threading aninvite_helperparam through three methods for a bounded fix.