feat(autofix): Prune stale check suites before consuming CI feedback - #122775
Draft
joseph-sentry wants to merge 1 commit into
Draft
feat(autofix): Prune stale check suites before consuming CI feedback#122775joseph-sentry wants to merge 1 commit into
joseph-sentry wants to merge 1 commit into
Conversation
A check suite that finished on a commit the PR has since moved past should not burn an iteration. should_consume only compared the suite's head against Seer's recorded repo_pr_states.commit_sha, which lags pushes, so a superseded suite still read as current. The live read runs as the last stage, only for suites the run-state and dedupe checks have already agreed to consume, so the extra GitHub call is bounded. Everything short of a definitive mismatch fails open — a GitHub or integration failure can never silently stop CI feedback.
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A check suite that finished on a commit the PR has since moved past
should not burn an iteration. should_consume only compared the suite's
head against Seer's recorded repo_pr_states.commit_sha, which lags
pushes, so a superseded suite still read as current.
The live read runs as the last stage, only for suites the run-state and
dedupe checks have already agreed to consume, so the extra GitHub call
is bounded.
Everything short of a definitive mismatch fails open — a
GitHub or integration failure can never silently stop CI feedback.