fix(detectors): Use correct key for transaction name#120118
Merged
lobsterkatie merged 1 commit intoJul 20, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
lobsterkatie
marked this pull request as ready for review
July 20, 2026 20:00
roggenkemper
approved these changes
Jul 20, 2026
lobsterkatie
deleted the
kmclb-fix-getting-transaction-name-in-existing-detectors
branch
July 20, 2026 20:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in a few of the existing issue detectors which is causing a false positive mismatch in the existing-vs-span-first-detectors experiment. In most of the existing detectors, we correctly look at
event["transaction"]to get the value forevidence_data.transaction_name, but in a few we instead look atevent["description"], even though events have never had a top-leveldescriptionfield. (The fact that this mistake is replicated across four detectors appears to just be copy-pasta.)