Skip to content

fix(eslint): improve the prefer-info-text eslint rule#120004

Merged
TkDodo merged 15 commits into
masterfrom
tkdodo/ref/improve-prefer-info-text
Jul 21, 2026
Merged

fix(eslint): improve the prefer-info-text eslint rule#120004
TkDodo merged 15 commits into
masterfrom
tkdodo/ref/improve-prefer-info-text

Conversation

@TkDodo

@TkDodo TkDodo commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

The lint rule now covers more cases, such as showOnlyOnOverflow and delay, which are now both supported by InfoText. Also migrate new violations to InfoText

The lint rule now covers more cases, such as `showOnlyOnOverflow` and `delay`, which are now both supported by InfoText. Also migrate new violations to InfoText
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 18, 2026
@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Story previews

Preview the stories changed in this PR on the Vercel deployment:

Preview deployment: https://sentry-rf6kcvbjw.sentry.dev

@TkDodo

TkDodo commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator Author

bugbot run

Comment thread static/eslint/eslintPluginScraps/src/rules/prefer-info-text.ts Outdated
Comment thread static/eslint/eslintPluginScraps/src/rules/preferInfoText.ts
Comment thread static/app/views/seerWorkflows/index.tsx
Comment thread static/app/views/explore/conversations/components/conversationsTableNew.tsx Outdated
@TkDodo

TkDodo commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator Author

bugbot run

Comment thread static/app/views/explore/conversations/components/conversationsTableNew.tsx Outdated
Comment thread static/app/views/seerWorkflows/index.tsx
TkDodo added 4 commits July 20, 2026 10:10
Links are interactive already so there's no need for InfoText. The fix is to put the tooltip onto the link and have a Text inside it
@TkDodo

TkDodo commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

bugbot run

Comment thread static/app/components/core/info/infoText.tsx
Comment thread static/app/components/preprod/preprodBuildsTableCommon.tsx
@TkDodo

TkDodo commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 29b6bc3. Configure here.

@TkDodo
TkDodo marked this pull request as ready for review July 20, 2026 13:04
@TkDodo
TkDodo requested review from a team as code owners July 20, 2026 13:04
@TkDodo
TkDodo merged commit ec8eb44 into master Jul 21, 2026
79 checks passed
@TkDodo
TkDodo deleted the tkdodo/ref/improve-prefer-info-text branch July 21, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants