fix: safely access description field in MN+1 DB span detector#119472
Draft
billyvg wants to merge 1 commit into
Draft
fix: safely access description field in MN+1 DB span detector#119472billyvg wants to merge 1 commit into
billyvg wants to merge 1 commit into
Conversation
Spans from downsampled data may lack a "description" key, causing KeyError in _maybe_performance_problem and failing all performance problem detection for that segment. Use .get() with an empty string default to handle spans without a description field gracefully. Fixes SENTRY-5QVD
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
KeyError: 'description'that crashes performance problem detection for segments containing spans without adescriptionfield. Spans from downsampled data (withdownsampled_retention_daysset) may omit thedescriptionkey, causing_maybe_performance_probleminContinuingMNPlusOneto raise and silently swallow the exception, losing all performance detection for that segment.Root cause: Two direct dict key accesses
db_span["description"]inmn_plus_one_db_span_detector.pylines 258 and 283 — one for thePerformanceProblem.descfield and one for theIssueEvidencedisplay value.Fix: Changed both to
db_span.get("description", "").Evidence
Sentry issue: SENTRY-5QVD —
KeyError: 'description'inmn_plus_one_db_span_detector.py:258spans.consumers.process_segments.process_segmentStack trace confirms the span's local variables show
{"downsampled_retention_days":"30", ...}without adescriptionfield.Seer analysis: "Use .get('description', '') to safely access the db span description."
Session
This fix was identified and created by Claude Code: https://claude.ai/code/session_01JhWfwrF5pc1GH772kWC27t
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Generated by Claude Code