fix(release-bubbles): guard against disposed echartsInstance in mouse handlers#119471
Draft
billyvg wants to merge 1 commit into
Draft
fix(release-bubbles): guard against disposed echartsInstance in mouse handlers#119471billyvg wants to merge 1 commit into
billyvg wants to merge 1 commit into
Conversation
… handlers ECharts instances can be disposed during React unmount while mouse events are still in-flight, causing `setOption`/`dispatchAction` calls to crash with "Cannot read properties of undefined (reading 'get')". Add `isDisposed()` checks to all four mouse event handlers (handleMouseMove, handleMouseOver, handleMouseOut, handleGlobalOut) so they bail early when the instance is no longer valid. Fixes JAVASCRIPT-3AP8
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes JAVASCRIPT-3AP8 —
TypeError: Cannot read properties of undefined (reading 'get')inuseReleaseBubbles.tsx, escalating with 195 users impacted.Root cause: ECharts instances can be disposed during React component unmount/re-render while mouse events (
mouseover,mouseout,globalout,mousemove) are still in-flight. WhensetOption,getOption, ordispatchActionare called on a disposed instance, ECharts' internalGlobalModel._mergeOptiontries to call.get()on a series model that no longer exists, throwing the uncaught TypeError.Evidence from Sentry issue JAVASCRIPT-3AP8:
handleMouseOut→echartsInstance.setOption(...)at line 552 ofuseReleaseBubbles.tsxecharts/lib/component/marker/MarkerModel.js:98—seriesModel.get(this.mainType, true)whereseriesModelis undefinedmousemoveevents on theEventGraph-Grid > ChartContainer > BaseChart > ReactEchartsCoreelement!echartsInstancenull check is insufficient — a disposed instance is still truthyFix: Add
echartsInstance.isDisposed()guard to all four mouse event handlers (handleMouseMove,handleMouseOver,handleMouseOut,handleGlobalOut). The ECharts API exposesisDisposed(): booleanexactly for this purpose.Analysis Session
https://claude.ai/code/session_01KEXsNpah4hsB8C56Uzb3RJ
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Generated by Claude Code